From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-177.mta1.migadu.com (out-177.mta1.migadu.com [95.215.58.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F29E6312836 for ; Wed, 26 Nov 2025 18:22:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=95.215.58.177 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764181366; cv=none; b=mttxoZEeY2jdzwpF/bwi3xEEb9IuWns0eyVYMRvRTCz4TD+aBNVl5i6Ma3hbbz/BsqnrpQUqdjP+UWiIgSNFrwL++94iiP/sHbIpN+RqbImw7OxlH9CWJEfrGr22pnCwMVetc6L7FD9m5OQehGioCzHhgelJLQ3vvPc9MULDPXw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764181366; c=relaxed/simple; bh=11+n6ED0oj4GlVfro7776FjNWhcM74GpNCK3Tx4RzU8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=kV+u/oFbwp0wdY4cnE89KU8uRzpFFfK1vrqdSf/zibdC+QgZZR1hiSdIhhQCtG2/T2hKOFiKpGM/pF75dLdreNukPtu1td6Cpi/u9Lvhq1lo8jxyIsJEckpEQrrn8Yo5Cl5Yaj4fiaprqMvGoEqhtLZb36sibbqK6Ot/8vhbNEo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=kBLIQ2D9; arc=none smtp.client-ip=95.215.58.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="kBLIQ2D9" Message-ID: <102a3220-2490-4c81-b2c9-6b107d6e4aff@linux.dev> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1764181351; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=b5lnVEmMjTQunScWht2/TigkN5EtXsb7CslpuxT4iIY=; b=kBLIQ2D9+46RfxQscZxA2XbmkNw2KlF45o/VXrEzwlTmpM/33kdUcRiUsJBdDj4WKBihIA 5060+ffqWI7XBRJMtqScZzGWXxvPTLBi0saW50GcRGyBtl4CVkGy8IZij/jN1OID6IS8WJ lg1zYeyciryXqWZaKfJnBXABvuxWlXI= Date: Wed, 26 Nov 2025 10:22:21 -0800 Precedence: bulk X-Mailing-List: dwarves@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Subject: Re: [PATCH bpf-next v1 4/4] resolve_btfids: change in-place update with raw binary output To: Donglin Peng Cc: Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Martin KaFai Lau , Eduard Zingerman , Song Liu , Yonghong Song , John Fastabend , KP Singh , Stanislav Fomichev , Hao Luo , Jiri Olsa , Nathan Chancellor , Nicolas Schier , Nick Desaulniers , Bill Wendling , Justin Stitt , bpf@vger.kernel.org, dwarves@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kbuild@vger.kernel.org, Alan Maguire References: <20251126012656.3546071-1-ihor.solodrai@linux.dev> <20251126012656.3546071-5-ihor.solodrai@linux.dev> Content-Language: en-US X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Ihor Solodrai In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Migadu-Flow: FLOW_OUT On 11/25/25 8:46 PM, Donglin Peng wrote: > On Wed, Nov 26, 2025 at 9:29 AM Ihor Solodrai wrote: >> >> [...] >> + >> +gen_btf_data() >> +{ >> + info BTF "${ELF_FILE}" >> + btf1="${ELF_FILE}.btf.1" >> + ${PAHOLE} -J ${PAHOLE_FLAGS} \ >> + ${BTF_BASE:+--btf_base ${BTF_BASE}} \ >> + --btf_encode_detached=${btf1} \ >> + "${ELF_FILE}" >> + >> + info BTFIDS "${ELF_FILE}" >> + RESOLVE_BTFIDS_OPTS="" >> + if is_enabled CONFIG_WERROR; then >> + RESOLVE_BTFIDS_OPTS+=" --fatal_warnings " > > In POSIX sh, +=is undefined[1], and I encountered the following error: > > ./scripts/gen-btf.sh: 90: RESOLVE_BTFIDS_OPTS+= --fatal_warnings : not found > > We should use the following syntax instead: > > RESOLVE_BTFIDS_OPTS="${RESOLVE_BTFIDS_OPTS} --fatal_warnings " Hi Donglin, thanks for taking a look. These and a couple of other bugs have been caught by CI [1]. I am working on v2. I changed the script to #!/bin/bash and will run the shellcheck before submitting the next revision [2], when it's ready. [1] https://github.com/kernel-patches/bpf/actions/runs/19689674975 [2] https://github.com/kernel-patches/bpf/pull/10370 > > [1] https://www.shellcheck.net/wiki/SC3024 > > Thanks, > Donglin >> [...]