Re: [PATCH dwarves v1] btf_encoder: move ambiguous_addr flag to elf_function

[Alan Maguire <alan.maguire@oracle.com>]

On 20/09/2025 01:43, Ihor Solodrai wrote:
> On 9/19/25 5:36 PM, Ihor Solodrai wrote:
>> Having an "ambiguous address" in the context of BTF encoding is an
>> attribute of an ELF function, and not any specific DWARF instance of
>> it. Thus it is redundant to maintain this flag in every
>> btf_encoder_func_state, and merging them in btf_encoder__save_func().
>>
>> Signed-off-by: Ihor Solodrai <ihor.solodrai@linux.dev>
>> ---
>>  btf_encoder.c | 47 ++++++++++++++++++++++++-----------------------
>>  1 file changed, 24 insertions(+), 23 deletions(-)
>>
>> [...]
> Hi Alan,
> 
> I've just noticed that you merged v2 of "btf_encoder: group all
> function ELF syms by function name" and not v3 [1] as I expected.
> 
> This patch is essentialy v2->v3 diff merged into current next.
> 
> vmlinux.h is identical between this patch and pahole/next (09c1e9c)
> for a sample vmlinux I had at hand.
> 
> Successful CI checks: https://github.com/acmel/dwarves/pull/70/checks
> 
> [1] https://lore.kernel.org/dwarves/20250801202009.3942492-1-ihor.solodrai@linux.dev/

applied to the next branch of

https://git.kernel.org/pub/scm/devel/pahole/pahole.git/

Thanks!

Alan