Dwarves debugging tools
 help / color / mirror / Atom feed
From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Andrii Nakryiko <andrii.nakryiko@gmail.com>
Cc: Andrii Nakryiko <andrii@kernel.org>,
	dwarves@vger.kernel.org, Alexei Starovoitov <ast@kernel.org>
Subject: Re: [PATCH dwarves] cmake: make libbpf's Linux UAPI headers available to all binaries
Date: Tue, 27 Oct 2020 08:20:50 -0300	[thread overview]
Message-ID: <20201027112050.GI2449445@kernel.org> (raw)
In-Reply-To: <CAEf4BzZ7TwoFJRq0uNs+w5bdXKPoswJzzfcaOn9FNNfTt1Ai7A@mail.gmail.com>

Em Mon, Oct 26, 2020 at 04:26:22PM -0700, Andrii Nakryiko escreveu:
> On Mon, Oct 26, 2020 at 12:49 PM Arnaldo Carvalho de Melo
> <acme@kernel.org> wrote:
> >
> > Em Sat, Oct 24, 2020 at 11:36:53AM -0700, Andrii Nakryiko escreveu:
> > > Now that libbpf is used to implement deduplicated strings container, all of
> > > the binaries will need linux/btf.h header to compile properly. libbpf is
> > > distributed with its own copies of Linux UAPI headers, so use them during
> > > compilation.
> >
> > Thanks, applied.
> >
> 
> Still don't see it at
> https://git.kernel.org/pub/scm/devel/pahole/pahole.git/, did you
> forget to push? This is breaking libbpf and kernel CIs at the moment
> :(

That got delayed due to that 'void variable found' bug that Hao fixed, I
just tested built a kernel with it, rebooting with it, some more testing
and it'll go to the public repo,

- Arnaldo
 
> > - Arnaldo
> >
> > > Signed-off-by: Andrii Nakryiko <andrii@kernel.org>
> > > ---
> > >  CMakeLists.txt | 4 +++-
> > >  1 file changed, 3 insertions(+), 1 deletion(-)
> > >
> > > diff --git a/CMakeLists.txt b/CMakeLists.txt
> > > index 8e9fe4710a0c..84693514e0c8 100644
> > > --- a/CMakeLists.txt
> > > +++ b/CMakeLists.txt
> > > @@ -2,7 +2,9 @@ project(pahole C)
> > >  cmake_minimum_required(VERSION 2.8.8)
> > >  cmake_policy(SET CMP0005 NEW)
> > >
> > > -INCLUDE_DIRECTORIES( ${CMAKE_CURRENT_BINARY_DIR} ${CMAKE_CURRENT_SOURCE_DIR} )
> > > +INCLUDE_DIRECTORIES(${CMAKE_CURRENT_BINARY_DIR}
> > > +                 ${CMAKE_CURRENT_SOURCE_DIR}
> > > +                 ${CMAKE_CURRENT_SOURCE_DIR}/lib/bpf/include/uapi)
> > >
> > >  # Try to parse this later, Helio just showed me a KDE4 example to support
> > >  # x86-64 builds.
> > > --
> > > 2.24.1
> > >
> >
> > --
> >
> > - Arnaldo

-- 

- Arnaldo

  reply	other threads:[~2020-10-27 11:20 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-24 18:36 [PATCH dwarves] cmake: make libbpf's Linux UAPI headers available to all binaries Andrii Nakryiko
2020-10-26 19:49 ` Arnaldo Carvalho de Melo
2020-10-26 23:26   ` Andrii Nakryiko
2020-10-27 11:20     ` Arnaldo Carvalho de Melo [this message]
2020-10-27 12:22       ` Arnaldo Carvalho de Melo
2020-10-27 18:02         ` Andrii Nakryiko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201027112050.GI2449445@kernel.org \
    --to=acme@kernel.org \
    --cc=andrii.nakryiko@gmail.com \
    --cc=andrii@kernel.org \
    --cc=ast@kernel.org \
    --cc=dwarves@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox