From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AA9D7C2D0A3 for ; Mon, 16 Nov 2020 19:46:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 538EA2075E for ; Mon, 16 Nov 2020 19:46:25 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="HWue5QrP" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727683AbgKPTqE (ORCPT ); Mon, 16 Nov 2020 14:46:04 -0500 Received: from mail.kernel.org ([198.145.29.99]:44248 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726156AbgKPTqE (ORCPT ); Mon, 16 Nov 2020 14:46:04 -0500 Received: from quaco.ghostprotocols.net (unknown [179.97.37.151]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id B2E012075A; Mon, 16 Nov 2020 19:46:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1605555963; bh=/+xXvI2ETifngASo+n380WxmfkRkW6lYKn5v2q9WRhk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=HWue5QrPF8iXpZanFb3wu7K2KraHU25NKW3MDLT7mWUQlPX4oNYg2fCNSNNMSvp0z y7bq/p1wI1jwKkKpUiHIqp6L9G2V3ndMzyztEdBe0/mZh17j/FtvKE/HlGmlN0imv7 9SOUwKKRH/PsSwlTPw8F59jiVht1kgh5WWYYM+UU= Received: by quaco.ghostprotocols.net (Postfix, from userid 1000) id 9F7C140E29; Mon, 16 Nov 2020 16:46:01 -0300 (-03) Date: Mon, 16 Nov 2020 16:46:01 -0300 From: Arnaldo Carvalho de Melo To: Jiri Olsa Cc: dwarves@vger.kernel.org, bpf@vger.kernel.org, Alexei Starovoitov , Andrii Nakryiko , Yonghong Song , Hao Luo Subject: Re: [PATCH] btf_encoder: Move btf_elf__verbose/btf_elf__force setup Message-ID: <20201116194601.GH614220@kernel.org> References: <20201116193348.1222960-1-jolsa@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201116193348.1222960-1-jolsa@kernel.org> X-Url: http://acmel.wordpress.com Precedence: bulk List-ID: X-Mailing-List: dwarves@vger.kernel.org Em Mon, Nov 16, 2020 at 08:33:48PM +0100, Jiri Olsa escreveu: > With introduction of collect_symbols function, we moved the > percpu variables code before btf_elf__verbose/btf_elf__force > setup, so they don't have any effect in that code anymore. > > Also btf_elf__verbose is used in code that prepares ftrace > filter for functions generations, also called within > collect_symbols function. > > Moving btf_elf__verbose/btf_elf__force setup early in the > cu__encode_btf function, so we can get verbose messages > and see the effect of the force option. Thanks, applied. - Arnaldo > Signed-off-by: Jiri Olsa > --- > btf_encoder.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/btf_encoder.c b/btf_encoder.c > index f3f6291391ee..4f856cfd5577 100644 > --- a/btf_encoder.c > +++ b/btf_encoder.c > @@ -540,6 +540,9 @@ int cu__encode_btf(struct cu *cu, int verbose, bool force, > struct tag *pos; > int err = 0; > > + btf_elf__verbose = verbose; > + btf_elf__force = force; > + > if (btfe && strcmp(btfe->filename, cu->filename)) { > err = btf_encoder__encode(); > if (err) > @@ -579,8 +582,6 @@ int cu__encode_btf(struct cu *cu, int verbose, bool force, > } > } > > - btf_elf__verbose = verbose; > - btf_elf__force = force; > type_id_off = btf__get_nr_types(btfe->btf); > > cu__for_each_type(cu, core_id, pos) { > -- > 2.26.2 > -- - Arnaldo