Dwarves debugging tools
 help / color / mirror / Atom feed
From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Mark Wielaard <mark@klomp.org>
Cc: dwarves@vger.kernel.org
Subject: Re: [PATCH] Handle DWARF5 DW_TAG_call_site like DW_TAG_GNU_call_site
Date: Mon, 1 Feb 2021 09:30:19 -0300	[thread overview]
Message-ID: <20210201123019.GF794568@kernel.org> (raw)
In-Reply-To: <20210131002731.60086-1-mark@klomp.org>

Em Sun, Jan 31, 2021 at 01:27:31AM +0100, Mark Wielaard escreveu:
> DW_TAG_call_site and DW_TAG_call_site_parameter are the standardized
> DWARF5 versions of DW_TAG_GNU_call_site and DW_TAG_GNU call_site_parameter.
> Handle them the same way (which is by ignoring them).

Thanks, I added these two lines, plese let me know if you're not ok with
it:

Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=1922698
Signed-off-by: Mark Wielaard <mark@klomp.org>

 
> https://bugzilla.redhat.com/show_bug.cgi?id=1922698
> ---
>  dwarf_loader.c | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/dwarf_loader.c b/dwarf_loader.c
> index ac22c1b..3bdf570 100644
> --- a/dwarf_loader.c
> +++ b/dwarf_loader.c
> @@ -41,6 +41,11 @@ struct strings *strings;
>  #define DW_TAG_GNU_call_site_parameter 0x410a
>  #endif
>  
> +#ifndef DW_TAG_call_site
> +#define DW_TAG_call_site 0x48
> +#define DW_TAG_call_site_parameter 0x49
> +#endif
> +
>  #define hashtags__fn(key) hash_64(key, HASHTAGS__BITS)
>  
>  bool no_bitfield_type_recode = true;
> @@ -1595,6 +1600,8 @@ static int die__process_function(Dwarf_Die *die, struct ftype *ftype,
>  		uint32_t id;
>  
>  		switch (dwarf_tag(die)) {
> +		case DW_TAG_call_site:
> +		case DW_TAG_call_site_parameter:
>  		case DW_TAG_GNU_call_site:
>  		case DW_TAG_GNU_call_site_parameter:
>  			/*
> -- 
> 2.20.1
> 

-- 

- Arnaldo

  reply	other threads:[~2021-02-01 12:31 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-31  0:27 [PATCH] Handle DWARF5 DW_TAG_call_site like DW_TAG_GNU_call_site Mark Wielaard
2021-02-01 12:30 ` Arnaldo Carvalho de Melo [this message]
2021-02-01 12:32   ` Mark Wielaard
2021-02-01 17:03     ` Arnaldo Carvalho de Melo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210201123019.GF794568@kernel.org \
    --to=acme@kernel.org \
    --cc=dwarves@vger.kernel.org \
    --cc=mark@klomp.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox