From: Bill Wendling <morbo@google.com>
To: dwarves@vger.kernel.org, bpf@vger.kernel.org
Cc: arnaldo.melo@gmail.com, Bill Wendling <morbo@google.com>
Subject: [PATCH v2] dwarf_loader: use a better hashing function
Date: Fri, 12 Feb 2021 00:01:04 -0800 [thread overview]
Message-ID: <20210212080104.2499483-1-morbo@google.com> (raw)
In-Reply-To: <20210210232327.1965876-1-morbo@google.com>
This hashing function[1] produces better hash table bucket
distributions. The original hashing function always produced zeros in
the three least significant bits. The new hashing function gives a
modest performance boost:
Original: 0:11.373s
New: 0:11.110s
for a performance improvement of ~2%.
[1] From the hash function used in libbpf.
Signed-off-by: Bill Wendling <morbo@google.com>
---
hash.h | 20 +-------------------
1 file changed, 1 insertion(+), 19 deletions(-)
diff --git a/hash.h b/hash.h
index d3aa416..6f952c7 100644
--- a/hash.h
+++ b/hash.h
@@ -33,25 +33,7 @@
static inline uint64_t hash_64(const uint64_t val, const unsigned int bits)
{
- uint64_t hash = val;
-
- /* Sigh, gcc can't optimise this alone like it does for 32 bits. */
- uint64_t n = hash;
- n <<= 18;
- hash -= n;
- n <<= 33;
- hash -= n;
- n <<= 3;
- hash += n;
- n <<= 3;
- hash -= n;
- n <<= 4;
- hash += n;
- n <<= 2;
- hash += n;
-
- /* High bits are more random, so use them. */
- return hash >> (64 - bits);
+ return (val * 11400714819323198485LLU) >> (64 - bits);
}
static inline uint32_t hash_32(uint32_t val, unsigned int bits)
--
2.30.0.478.g8a0d178c01-goog
next prev parent reply other threads:[~2021-02-12 8:01 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-10 23:23 [PATCH] dwarf_loader: use a better hashing function Bill Wendling
2021-02-10 23:59 ` Andrii Nakryiko
2021-02-11 1:24 ` Bill Wendling
2021-02-11 1:31 ` Andrii Nakryiko
2021-02-11 13:01 ` Arnaldo Carvalho de Melo
2021-02-12 6:55 ` Bill Wendling
2021-02-12 12:35 ` Arnaldo Carvalho de Melo
2021-02-12 8:01 ` Bill Wendling [this message]
2021-02-12 12:37 ` [PATCH v2] " Arnaldo Carvalho de Melo
2021-02-12 12:39 ` Arnaldo Carvalho de Melo
2021-02-12 20:14 ` Bill Wendling
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210212080104.2499483-1-morbo@google.com \
--to=morbo@google.com \
--cc=arnaldo.melo@gmail.com \
--cc=bpf@vger.kernel.org \
--cc=dwarves@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox