From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Willy Tarreau <w@1wt.eu>
Cc: dwarves@vger.kernel.org, Alan Maguire <alan.maguire@oracle.com>,
Jiri Olsa <jolsa@kernel.org>,
Clark Williams <williams@redhat.com>,
Kate Carcia <kcarcia@redhat.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
"Gustavo A. R. Silva" <gustavoars@kernel.org>
Subject: [PATCH RFC 0/5] pahole --with_embedded_flexible_array
Date: Mon, 7 Oct 2024 17:25:26 -0300 [thread overview]
Message-ID: <20241007202531.942648-1-acme@kernel.org> (raw)
Hi Willy, Gustavo,
Please take a look, there are still some odd cases where the
comment is not being emitted but _there_ is a flexible array inside the
struct marked as having a flexible array "in the middle" (by means of
an embedded struct that _has_ a flexible array.
This helps with one other case Gustavo talked about at KR.
Please take a look and give it some testing, please.
- Arnaldo
Arnaldo Carvalho de Melo (5):
core: Move class__has_flexible_array() from pahole to the core
core: Cache info about flexible arrays in class__has_flexible_array()
core: Introduce class__has_embedded_flexible_array()
fprintf: Add a comment if a member type has an embedded flexible array
pahole: Introduce --with_embedded_flexible_array
dwarves.c | 77 ++++++++++++++++++++++++++++++++++++++++++++++
dwarves.h | 6 ++++
dwarves_fprintf.c | 12 ++++++--
man-pages/pahole.1 | 4 +++
pahole.c | 36 ++++++++--------------
5 files changed, 109 insertions(+), 26 deletions(-)
--
2.46.2
next reply other threads:[~2024-10-07 20:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-07 20:25 Arnaldo Carvalho de Melo [this message]
2024-10-07 20:25 ` [PATCH 1/5] core: Move class__has_flexible_array() from pahole to the core Arnaldo Carvalho de Melo
2024-10-07 20:25 ` [PATCH 2/5] core: Cache info about flexible arrays in class__has_flexible_array() Arnaldo Carvalho de Melo
2024-10-07 20:25 ` [PATCH 3/5] core: Introduce class__has_embedded_flexible_array() Arnaldo Carvalho de Melo
2024-10-07 20:25 ` [PATCH 4/5] fprintf: Add a comment if a member type has an embedded flexible array Arnaldo Carvalho de Melo
2024-10-07 20:25 ` [PATCH 5/5] pahole: Introduce --with_embedded_flexible_array Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241007202531.942648-1-acme@kernel.org \
--to=acme@kernel.org \
--cc=alan.maguire@oracle.com \
--cc=dwarves@vger.kernel.org \
--cc=gustavoars@kernel.org \
--cc=jolsa@kernel.org \
--cc=kcarcia@redhat.com \
--cc=w@1wt.eu \
--cc=williams@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox