From: Eduard Zingerman <eddyz87@gmail.com>
To: dwarves@vger.kernel.org, arnaldo.melo@gmail.com
Cc: bpf@vger.kernel.org, kernel-team@fb.com, ast@kernel.org,
daniel@iogearbox.net, andrii@kernel.org, yonghong.song@linux.dev,
Eduard Zingerman <eddyz87@gmail.com>,
Alan Maguire <alan.maguire@oracle.com>, Daniel Xu <dxu@dxuuu.xyz>,
Jiri Olsa <olsajiri@gmail.com>,
Kumar Kartikeya Dwivedi <memxor@gmail.com>,
Vadim Fedorenko <vadfed@meta.com>
Subject: [PATCH dwarves v3 0/1] btf_encoder: handle .BTF_ids section endianness
Date: Tue, 26 Nov 2024 17:50:05 -0800 [thread overview]
Message-ID: <20241127015006.2013050-1-eddyz87@gmail.com> (raw)
Currently, pahole does not generate kfunc declaration tags when
generating BTF for ELF files with an endianness different from the
host system. For example, this issue occurs when processing a vmlinux
built for s390 on an x86 host.
To reproduce the bug:
- follow the instructions in [0] to build an s390 vmlinux;
- generate BTF requesting declaration tags for kfuncs:
$ pahole --btf_features_strict=decl_tag_kfuncs,decl_tag \
--btf_encode_detached=test.btf vmlinux
- observe that no kfuncs are generated:
$ bpftool btf dump file test.btf format c | grep __ksym
This patch resolves the issue by adding the necessary byte-swapping
operations.
Changelog:
- v1 [1] -> v2:
- avoid modifying the 'idlist' Elf_Data object directly.
Instead, use struct local_elf_data (suggested by Jiri);
- update the description of the .BTF_ids section (suggested by Jiri).
- v2 [2] -> v3:
- use elf_getdata_rawchunk() instead of direct conversion loop
(suggested by Andrii);
- removed Jiri's acked-by and Vadim's reviewed-by,
as patch had changed significantly.
[0] https://docs.kernel.org/bpf/s390.html
[1] https://lore.kernel.org/dwarves/20241122070218.3832680-1-eddyz87@gmail.com/
[2] https://lore.kernel.org/dwarves/20241122214431.292196-1-eddyz87@gmail.com/
Cc: Alan Maguire <alan.maguire@oracle.com>
Cc: Andrii Nakryiko <andrii@kernel.org>
Cc: Daniel Xu <dxu@dxuuu.xyz>
Cc: Jiri Olsa <olsajiri@gmail.com>
Cc: Kumar Kartikeya Dwivedi <memxor@gmail.com>
Cc: Vadim Fedorenko <vadfed@meta.com>
Eduard Zingerman (1):
btf_encoder: handle .BTF_ids section endianness
btf_encoder.c | 26 ++++++++++++++++++++------
1 file changed, 20 insertions(+), 6 deletions(-)
--
2.47.0
next reply other threads:[~2024-11-27 1:50 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-27 1:50 Eduard Zingerman [this message]
2024-11-27 1:50 ` [PATCH dwarves v3 1/1] btf_encoder: handle .BTF_ids section endianness Eduard Zingerman
2024-11-27 11:00 ` Jiri Olsa
2024-11-27 12:03 ` Vadim Fedorenko
2024-11-27 12:35 ` Jiri Olsa
2024-11-27 17:53 ` Eduard Zingerman
2024-11-27 13:59 ` Vadim Fedorenko
2024-11-28 20:26 ` Arnaldo Carvalho de Melo
2024-11-28 21:14 ` Eduard Zingerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241127015006.2013050-1-eddyz87@gmail.com \
--to=eddyz87@gmail.com \
--cc=alan.maguire@oracle.com \
--cc=andrii@kernel.org \
--cc=arnaldo.melo@gmail.com \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=dwarves@vger.kernel.org \
--cc=dxu@dxuuu.xyz \
--cc=kernel-team@fb.com \
--cc=memxor@gmail.com \
--cc=olsajiri@gmail.com \
--cc=vadfed@meta.com \
--cc=yonghong.song@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox