From: Christoph Hellwig <hch@lst.de>
To: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: dwarves@vger.kernel.org
Subject: Re: pahole treats embedded structures a holes
Date: Thu, 28 May 2026 15:58:52 +0200 [thread overview]
Message-ID: <20260528135852.GA30243@lst.de> (raw)
In-Reply-To: <ahhFlsCJzkxLt3M6@x1>
On Thu, May 28, 2026 at 10:39:34AM -0300, Arnaldo Carvalho de Melo wrote:
> > struct rhash_head is a single pointer, so 8 bytes on x86-64, and
> > xfs_daddr_t is also a 64-bit type, so both the 0 size and the 8
> > byte hole are clearly wrong. The kernel .config is attached in case
> > it matter.
>
> Starting from using the BTF info, that becomes available thru sysfs as
> soon as we load the xfs kernel module:
This works fine on my installed distro kernel as well. But this is
for test builds which are only going to run in a VM. I don't really
care about DWARF vs BTF, but I do care about not having to run the
kernel :)
Note that I'm also seeing this for other code than XFS, e.g. the nvme
driver or block layer code.
> Now I'll try with a fresh kernel build, with a default fedora kernel
> config, will take a while, but having access to a separate .o file from
> the kernel build process, with just DWARF info is what we need to get to
> the state you're in, that should work, lets see why you're getting the
> unsatisfactory results you're getting, maybe we need further info about
> compiler versions, etc, but lets see...
gcc (Debian 15.2.0-17) 15.2.0
next prev parent reply other threads:[~2026-05-28 13:58 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-28 5:11 pahole treats embedded structures a holes Christoph Hellwig
2026-05-28 13:39 ` Arnaldo Carvalho de Melo
2026-05-28 13:58 ` Christoph Hellwig [this message]
2026-05-28 19:48 ` Arnaldo Carvalho de Melo
2026-05-29 4:02 ` Christoph Hellwig
2026-05-29 19:28 ` Arnaldo Carvalho de Melo
-- strict thread matches above, loose matches on Subject: below --
2026-06-05 19:28 Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260528135852.GA30243@lst.de \
--to=hch@lst.de \
--cc=acme@kernel.org \
--cc=dwarves@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox