From: Eduard Zingerman <eddyz87@gmail.com>
To: Yonghong Song <yonghong.song@linux.dev>,
Alan Maguire <alan.maguire@oracle.com>,
acme@kernel.org
Cc: dwarves@vger.kernel.org, ast@kernel.org, andrii@kernel.org,
bpf@vger.kernel.org, daniel@iogearbox.net, kernel-team@fb.com,
song@kernel.org, olsajiri@gmail.com
Subject: Re: [PATCH v2 dwarves 1/2] dwarf_loader: Check DW_OP_[GNU_]entry_value for possible parameter matching
Date: Thu, 14 Nov 2024 13:38:02 -0800 [thread overview]
Message-ID: <49996d2679fa02a50d3ea7fbe5ccb6271017996c.camel@gmail.com> (raw)
In-Reply-To: <fa3f1a9b-7fee-42f4-9827-b28b1bb3eff6@linux.dev>
On Thu, 2024-11-14 at 12:04 -0800, Yonghong Song wrote:
[...]
> Should we do
> ...
> dwarf_getlocation(&entry_attr, &entry_ops, &entry_len) == 0 &&
> entry_len == 1 && expr->atom == expected_reg) {
> ret = entry_ops->atom;
> goto out;
> }
> ...
> ?
Makes sense to me.
next prev parent reply other threads:[~2024-11-14 21:38 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-14 15:58 [PATCH v2 dwarves 0/2] Check DW_OP_[GNU_]entry_value for possible parameter matching Alan Maguire
2024-11-14 15:58 ` [PATCH v2 dwarves 1/2] dwarf_loader: " Alan Maguire
2024-11-14 16:51 ` Yonghong Song
2024-11-14 16:59 ` Alan Maguire
2024-11-14 18:21 ` Eduard Zingerman
2024-11-14 20:04 ` Yonghong Song
2024-11-14 21:38 ` Eduard Zingerman [this message]
2024-11-15 8:47 ` Jiri Olsa
2024-11-14 15:58 ` [PATCH v2 dwarves 2/2] dwarf_loader: use libdw__lock for Alan Maguire
2024-11-14 18:01 ` Eduard Zingerman
2024-11-15 9:34 ` [PATCH v2 dwarves 0/2] Check DW_OP_[GNU_]entry_value for possible parameter matching Jiri Olsa
2024-11-15 14:52 ` Arnaldo Carvalho de Melo
2024-11-15 15:00 ` Jiri Olsa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49996d2679fa02a50d3ea7fbe5ccb6271017996c.camel@gmail.com \
--to=eddyz87@gmail.com \
--cc=acme@kernel.org \
--cc=alan.maguire@oracle.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=dwarves@vger.kernel.org \
--cc=kernel-team@fb.com \
--cc=olsajiri@gmail.com \
--cc=song@kernel.org \
--cc=yonghong.song@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox