public inbox for dwarves@vger.kernel.org
 help / color / mirror / Atom feed
From: Ihor Solodrai <ihor.solodrai@linux.dev>
To: alan.maguire@oracle.com, dwarves@vger.kernel.org
Cc: bpf@vger.kernel.org, acme@kernel.org, andrii@kernel.org,
	ast@kernel.org, eddyz87@gmail.com, olsajiri@gmail.com,
	kernel-team@meta.com
Subject: Re: [PATCH dwarves v1] btf_encoder: move ambiguous_addr flag to elf_function
Date: Fri, 19 Sep 2025 17:43:22 -0700	[thread overview]
Message-ID: <580f039a-72eb-417b-a435-d9ec0661fb96@linux.dev> (raw)
In-Reply-To: <20250920003656.3592976-1-ihor.solodrai@linux.dev>

On 9/19/25 5:36 PM, Ihor Solodrai wrote:
> Having an "ambiguous address" in the context of BTF encoding is an
> attribute of an ELF function, and not any specific DWARF instance of
> it. Thus it is redundant to maintain this flag in every
> btf_encoder_func_state, and merging them in btf_encoder__save_func().
> 
> Signed-off-by: Ihor Solodrai <ihor.solodrai@linux.dev>
> ---
>  btf_encoder.c | 47 ++++++++++++++++++++++++-----------------------
>  1 file changed, 24 insertions(+), 23 deletions(-)
> 
> [...]
Hi Alan,

I've just noticed that you merged v2 of "btf_encoder: group all
function ELF syms by function name" and not v3 [1] as I expected.

This patch is essentialy v2->v3 diff merged into current next.

vmlinux.h is identical between this patch and pahole/next (09c1e9c)
for a sample vmlinux I had at hand.

Successful CI checks: https://github.com/acmel/dwarves/pull/70/checks

[1] https://lore.kernel.org/dwarves/20250801202009.3942492-1-ihor.solodrai@linux.dev/

  reply	other threads:[~2025-09-20  0:43 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-20  0:36 [PATCH dwarves v1] btf_encoder: move ambiguous_addr flag to elf_function Ihor Solodrai
2025-09-20  0:43 ` Ihor Solodrai [this message]
2025-09-22 11:59   ` Alan Maguire
2025-10-09 12:40   ` Alan Maguire

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=580f039a-72eb-417b-a435-d9ec0661fb96@linux.dev \
    --to=ihor.solodrai@linux.dev \
    --cc=acme@kernel.org \
    --cc=alan.maguire@oracle.com \
    --cc=andrii@kernel.org \
    --cc=ast@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=dwarves@vger.kernel.org \
    --cc=eddyz87@gmail.com \
    --cc=kernel-team@meta.com \
    --cc=olsajiri@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox