From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-187.mta1.migadu.com (out-187.mta1.migadu.com [95.215.58.187]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 591253126BC for ; Wed, 26 Nov 2025 19:13:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=95.215.58.187 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764184401; cv=none; b=p8RzWC9bR4yylwiBCa4C1DenafjAtF3f8X+lkMqf4H56sQrad0rgpmf4C8KNyAweWyO0Hlieo+QDKXunD/X+bzZyhGzabypROFLEasuWDEJSDbUK2O0OgnPrguVY4wfBt08W4QPwOI2fibrtqylzfrm6u0cd0O0I5bohEVPBUrw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764184401; c=relaxed/simple; bh=N0Zb+RrDajauwjsyN6i28AMVPOJUhfk5DbUUzMwggys=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=dzj9du2BXOsCQD0pwH+t8M/6A1QzWflPAcDu7Sg6313JsLjVt6fmnauvb3BrURoQ3dE04jxcl4NxNufg/jzdGU9C0gOd5jIDE89n1zLxqs5x5l44qqq3mtO4MOs0TXcxXPVpVcstOa8fCLTS5B8jQTAblvK8ue4xNTce/2Ye7UI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=xvW14r6M; arc=none smtp.client-ip=95.215.58.187 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="xvW14r6M" Message-ID: <6b61c22b-d38c-47c1-8b8f-a37e44866644@linux.dev> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1764184396; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=oj7a/chW6SNwlrR4P2Y5EG7P7Q7f9ZjCmFxdGZ83m2c=; b=xvW14r6MwplzZCEMbwn7A8A5jtx0DN9DcCMJSK0NDmNKOyL8XG8Tv7TwV2bWk44sVCEGbi GAL8rrEGFMQ+esPBU+v0Uc5zM2A4hnwP9Txc+Z1bqMfiEYj/673tCW1sKhwu+S4ce2lRAz IfIA22ebNUlPHWZEylq3zBBIQuW2pFc= Date: Wed, 26 Nov 2025 11:13:07 -0800 Precedence: bulk X-Mailing-List: dwarves@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Subject: Re: [PATCH bpf-next v1 4/4] resolve_btfids: change in-place update with raw binary output To: Donglin Peng Cc: Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Martin KaFai Lau , Eduard Zingerman , Song Liu , Yonghong Song , John Fastabend , KP Singh , Stanislav Fomichev , Hao Luo , Jiri Olsa , Nathan Chancellor , Nicolas Schier , Nick Desaulniers , Bill Wendling , Justin Stitt , bpf@vger.kernel.org, dwarves@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kbuild@vger.kernel.org, Alan Maguire References: <20251126012656.3546071-1-ihor.solodrai@linux.dev> <20251126012656.3546071-5-ihor.solodrai@linux.dev> Content-Language: en-US X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Ihor Solodrai In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Migadu-Flow: FLOW_OUT On 11/26/25 5:03 AM, Donglin Peng wrote: > On Wed, Nov 26, 2025 at 9:29 AM Ihor Solodrai wrote: >> >> [...] >> >> For the kernel modules creating special .bpf.o file is not necessary, >> and so embedding of sections data produced by resolve_btfids is >> straightforward with the objcopy. > > The Makefile for the bpf selftests also needs be updated too: > https://elixir.bootlin.com/linux/v6.18-rc7/source/tools/testing/selftests/bpf/Makefile#L708 > > This results in the self-test for resolve_btfids failing: > $./vmtest.sh -- ./test_progs -t resolve_btfids -v > ... > test_resolve_btfids:PASS:id_check 0 nsec > test_resolve_btfids:FAIL:id_check wrong ID for S (0 != 3) Good catch, thanks. I remember I noticed this at some point, and then forgot... Interestingly this test passes on CI [1]: 2025-11-26T03:09:52.0908317Z #366 reg_bounds_rand_ranges_u64_u64:OK 2025-11-26T03:09:52.0925114Z #367 resolve_btfids:OK 2025-11-26T03:09:52.3904190Z #368/1 res_spin_lock_failure/res_spin_lock_arg:OK I'll take a closer look. [1] https://github.com/kernel-patches/bpf/actions/runs/19690981192/job/56406840021 > > >> [...] >>