From: "Ihor Solodrai" <ihor.solodrai@linux.dev>
To: "Alan Maguire" <alan.maguire@oracle.com>,
dwarves@vger.kernel.org, bpf@vger.kernel.org
Cc: acme@kernel.org, ast@kernel.org, andrii@kernel.org,
eddyz87@gmail.com, mykolal@fb.com, kernel-team@meta.com
Subject: Re: [PATCH dwarves v4 0/6] btf_encoder: emit type tags for bpf_arena pointers
Date: Wed, 26 Mar 2025 17:41:28 +0000 [thread overview]
Message-ID: <70bf9434663f748563e5e464ac76bab669d0acf9@linux.dev> (raw)
In-Reply-To: <e9c86b63-7715-4232-869e-8835eead9a8e@oracle.com>
On 3/25/25 2:59 AM, Alan Maguire wrote:
>
> [...]
>
> Great; so let's do this to land the series. Could you either
>
> - check I merged your patches correctly in the above branch, and if they
> look good I'll merge them into next and I'll officially send the feature
> check patch; or if you'd prefer
> - send a v5 (perhaps including my feature check patch?)
>
> ...whichever approach is easiest for you.
Hi Alan.
I reviewed the diff between your branch:
https://web.git.kernel.org/pub/scm/devel/pahole/pahole.git/log/?h=next.attributes-v4
and v1.29 + my patchset:
https://github.com/theihor/dwarves/tree/v4.kf-arena
Not a lot of difference besides your patch.
Didn't spot any problems.
I also ran a couple of tests on your branch:
* generate BTF with and without --btf_feature=attributes
* run ./tests/tests on 6.14-rc3 vmlinux (just a build I had at hand)
I think you can apply patches from next.attributes-v4 as is.
Thank you.
>
> Thanks!
>
> Alan
next prev parent reply other threads:[~2025-03-26 17:41 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-28 19:46 [PATCH dwarves v4 0/6] btf_encoder: emit type tags for bpf_arena pointers Ihor Solodrai
2025-02-28 19:46 ` [PATCH dwarves v4 1/6] btf_encoder: refactor btf_encoder__tag_kfuncs() Ihor Solodrai
2025-02-28 19:46 ` [PATCH dwarves v4 2/6] btf_encoder: use __weak declarations of version-dependent libbpf API Ihor Solodrai
2025-02-28 19:53 ` Ihor Solodrai
2025-03-06 17:14 ` Alan Maguire
2025-02-28 19:46 ` [PATCH dwarves v4 3/6] pahole: sync with libbpf mainline Ihor Solodrai
2025-02-28 19:46 ` [PATCH dwarves v4 4/6] btf_encoder: emit type tags for bpf_arena pointers Ihor Solodrai
2025-02-28 19:46 ` [PATCH dwarves v4 5/6] pahole: introduce --btf_feature=attributes Ihor Solodrai
2025-02-28 19:46 ` [PATCH dwarves v4 6/6] man-pages: describe attributes and remove reproducible_build Ihor Solodrai
2025-03-20 16:32 ` [PATCH dwarves v4 0/6] btf_encoder: emit type tags for bpf_arena pointers Ihor Solodrai
2025-03-20 20:34 ` Alan Maguire
2025-03-23 11:11 ` Alan Maguire
2025-03-24 18:07 ` Ihor Solodrai
2025-03-24 18:47 ` Ihor Solodrai
2025-03-25 9:59 ` Alan Maguire
2025-03-26 17:41 ` Ihor Solodrai [this message]
2025-03-27 8:22 ` Alan Maguire
2025-03-27 15:33 ` Ihor Solodrai
2025-03-27 15:40 ` Alan Maguire
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=70bf9434663f748563e5e464ac76bab669d0acf9@linux.dev \
--to=ihor.solodrai@linux.dev \
--cc=acme@kernel.org \
--cc=alan.maguire@oracle.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=dwarves@vger.kernel.org \
--cc=eddyz87@gmail.com \
--cc=kernel-team@meta.com \
--cc=mykolal@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox