From: Eduard Zingerman <eddyz87@gmail.com>
To: Arnaldo Carvalho de Melo <acme@kernel.org>, dwarves@vger.kernel.org
Cc: "Jiri Olsa" <jolsa@kernel.org>,
"Clark Williams" <williams@redhat.com>,
"Kate Carcia" <kcarcia@redhat.com>,
bpf@vger.kernel.org, "Alan Maguire" <alan.maguire@oracle.com>,
"Kui-Feng Lee" <kuifeng@fb.com>,
"Thomas Weißschuh" <linux@weissschuh.net>
Subject: Re: [RFC/PATCHES 00/12] pahole: Reproducible parallel DWARF loading/serial BTF encoding
Date: Thu, 04 Apr 2024 03:08:08 +0300 [thread overview]
Message-ID: <747816d2edd61a075d200ffa5da680d2cc2d6854.camel@gmail.com> (raw)
In-Reply-To: <20240402193945.17327-1-acme@kernel.org>
On Tue, 2024-04-02 at 16:39 -0300, Arnaldo Carvalho de Melo wrote:
> Hi,
>
> This allows us to have reproducible builds while keeping the
> DWARF loading phase in parallel, achieving a noticeable speedup as
> showed in the commit log messages:
[...]
> Working on libbpf to allow for parallel reproducible BTF encoding is the
> next step.
Another option would be to apply some sort of canonical ordering to
BTF itself. E.g. put all PTR before STRUCT, sort same kinds by name,
sort same kinds by vlen, etc. Something akin to [1], however this
experiment has several flaws:
- slowdown is much worse than with your patch-set;
- I see a small number of functions with identical names appearing and
disappearing from final BTF.
I'll try to figure out the reason for slowdown tomorrow.
[1] https://github.com/eddyz87/dwarves/tree/sort-btf
next prev parent reply other threads:[~2024-04-04 0:08 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-02 19:39 [RFC/PATCHES 00/12] pahole: Reproducible parallel DWARF loading/serial BTF encoding Arnaldo Carvalho de Melo
2024-04-02 19:39 ` [PATCH 01/12] core: Allow asking for a reproducible build Arnaldo Carvalho de Melo
2024-04-02 19:39 ` [PATCH 02/12] pahole: Disable BTF multithreaded encoded when doing reproducible builds Arnaldo Carvalho de Melo
2024-04-03 18:19 ` Andrii Nakryiko
2024-04-03 21:38 ` Arnaldo Carvalho de Melo
2024-04-03 21:43 ` Andrii Nakryiko
2024-04-04 9:42 ` Jiri Olsa
2024-04-02 19:39 ` [PATCH 03/12] dwarf_loader: Separate creating the cu/dcu pair from processing it Arnaldo Carvalho de Melo
2024-04-04 9:42 ` Jiri Olsa
2024-04-02 19:39 ` [PATCH 04/12] dwarf_loader: Introduce dwarf_cus__process_cu() Arnaldo Carvalho de Melo
2024-04-02 19:39 ` [PATCH 05/12] dwarf_loader: Create the cu/dcu pair in dwarf_cus__nextcu() Arnaldo Carvalho de Melo
2024-04-02 19:39 ` [PATCH 06/12] dwarf_loader: Remove unused 'thr_data' arg from dwarf_cus__create_and_process_cu() Arnaldo Carvalho de Melo
2024-04-02 19:39 ` [PATCH 07/12] core: Add unlocked cus__add() variant Arnaldo Carvalho de Melo
2024-04-02 19:39 ` [PATCH 08/12] core: Add cus__remove(), counterpart of cus__add() Arnaldo Carvalho de Melo
2024-04-02 19:39 ` [PATCH 09/12] dwarf_loader: Add the cu to the cus list early, remove on LSK_DELETE Arnaldo Carvalho de Melo
2024-04-02 19:39 ` [PATCH 10/12] core/dwarf_loader: Add functions to set state of CU processing Arnaldo Carvalho de Melo
2024-04-02 19:39 ` [PATCH 11/12] pahole: Encode BTF serially in a reproducible build Arnaldo Carvalho de Melo
2024-04-02 19:39 ` [PATCH 12/12] tests: Add a BTF reproducible generation test Arnaldo Carvalho de Melo
2024-04-04 0:08 ` Eduard Zingerman [this message]
2024-04-04 8:05 ` [RFC/PATCHES 00/12] pahole: Reproducible parallel DWARF loading/serial BTF encoding Alan Maguire
2024-04-09 14:34 ` Eduard Zingerman
2024-04-09 14:56 ` Alexei Starovoitov
2024-04-09 15:01 ` Eduard Zingerman
2024-04-09 18:45 ` Arnaldo Carvalho de Melo
2024-04-09 19:29 ` Eduard Zingerman
2024-04-09 19:34 ` Alexei Starovoitov
2024-04-09 19:57 ` Arnaldo Carvalho de Melo
2024-04-12 20:37 ` Arnaldo Carvalho de Melo
2024-04-12 20:40 ` Eduard Zingerman
2024-04-12 21:09 ` Arnaldo Carvalho de Melo
2024-04-12 21:10 ` Eduard Zingerman
2024-04-04 8:58 ` Alan Maguire
2024-04-08 12:00 ` Alan Maguire
2024-04-08 14:39 ` Arnaldo Carvalho de Melo
2024-04-12 20:36 ` Arnaldo Carvalho de Melo
2024-04-04 9:42 ` Jiri Olsa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=747816d2edd61a075d200ffa5da680d2cc2d6854.camel@gmail.com \
--to=eddyz87@gmail.com \
--cc=acme@kernel.org \
--cc=alan.maguire@oracle.com \
--cc=bpf@vger.kernel.org \
--cc=dwarves@vger.kernel.org \
--cc=jolsa@kernel.org \
--cc=kcarcia@redhat.com \
--cc=kuifeng@fb.com \
--cc=linux@weissschuh.net \
--cc=williams@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox