From: Eduard Zingerman <eddyz87@gmail.com>
To: Ihor Solodrai <ihor.solodrai@pm.me>,
Alan Maguire <alan.maguire@oracle.com>
Cc: acme@kernel.org, dwarves@vger.kernel.org, olsajiri@gmail.com,
shung-hsi.yu@suse.com, jirislaby@kernel.org
Subject: Re: [PATCH v2 dwarves 1/3] btf_encoder: record BTF-centric function state instead of DWARF-centric
Date: Tue, 24 Sep 2024 12:10:13 -0700 [thread overview]
Message-ID: <7f8babfd7156de98d089b2ed476dff7f652246a7.camel@gmail.com> (raw)
In-Reply-To: <aQtEzThpIhRiwQpkgeZepPGr5Mt_zuGfPbxQxZgS6SSoPYoqM1afjDqEmIZkdH3YzvhWmWwqCS_8ZvFTcSZHvpkAeBpLRTAZEmrOhq0svfo=@pm.me>
On Tue, 2024-09-24 at 19:02 +0000, Ihor Solodrai wrote:
> On Tuesday, September 24th, 2024 at 7:31 AM, Alan Maguire <alan.maguire@oracle.com> wrote:
[...]
> However, as I understand, Eduard suggests that these tables might be
> unnecessary at all, if the way of checking for and merging
> inconsistent functions is changed. Eduard, please feel free to correct
> me or expand on the idea.
I was thinking about keeping the functions in a separate BTF before
decision is made if that function has valid prototype.
But the table would still be necessary because of the flags tracked in:
struct parameter {
struct tag tag;
const char *name;
uint8_t optimized:1;
uint8_t unexpected_reg:1;
uint8_t has_loc:1;
};
I'd say let's ignore this for now and do a simple refactoring with a
lock/atomic that you describe.
next prev parent reply other threads:[~2024-09-24 19:10 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-16 13:49 [PATCH v2 dwarves 0/3] reduce memory overhead of BTF encoding Alan Maguire
2024-09-16 13:49 ` [PATCH v2 dwarves 1/3] btf_encoder: record BTF-centric function state instead of DWARF-centric Alan Maguire
2024-09-20 19:18 ` Eduard Zingerman
2024-09-24 14:31 ` Alan Maguire
2024-09-24 19:02 ` Ihor Solodrai
2024-09-24 19:10 ` Eduard Zingerman [this message]
2024-09-23 14:19 ` Jiri Olsa
2024-09-24 14:40 ` Alan Maguire
2024-09-16 13:49 ` [PATCH v2 dwarves 2/3] pfunct: show all functions that match filter criteria Alan Maguire
2024-09-16 13:49 ` [PATCH v2 dwarves 3/3] tests: add test validating BTF encoding, reasons we skip functions Alan Maguire
2024-09-18 8:41 ` Arnaldo Carvalho de Melo
2024-09-25 9:27 ` Alan Maguire
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7f8babfd7156de98d089b2ed476dff7f652246a7.camel@gmail.com \
--to=eddyz87@gmail.com \
--cc=acme@kernel.org \
--cc=alan.maguire@oracle.com \
--cc=dwarves@vger.kernel.org \
--cc=ihor.solodrai@pm.me \
--cc=jirislaby@kernel.org \
--cc=olsajiri@gmail.com \
--cc=shung-hsi.yu@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox