From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-173.mta1.migadu.com (out-173.mta1.migadu.com [95.215.58.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 544A7267383 for ; Wed, 9 Apr 2025 15:52:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=95.215.58.173 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744213931; cv=none; b=ohbDf8zw3bFVEnWM6Bu+DMC57Ed9YXRvs1T3+LumwFi95Esu4RYSJP0r9zb9B9mOp/J/6a75nzZrwZcFRvr35YNLFNxzDn1oNcKm0A0t2AqmIjxXH7MH4CrQOFjnI5t96cwCI4HzJWUYytJrBf5nRceRTD/slCeZPQUWOYLAX6c= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744213931; c=relaxed/simple; bh=yqPuxChioM5eOTScbVml1bVn4Avqwl3RX4UXAViXSiY=; h=MIME-Version:Date:Content-Type:From:Message-ID:Subject:To:Cc: In-Reply-To:References; b=CpeLz4fwGiMtn0J2Eg7fdfFju4VMaEKUaORapKkRxCa/yyes5y+Ce3va4MdIJ55TT6owwSmAVnoQNML7A/y/boM1L2JF7zEY/wRG4d5iP7b/A2L/lM68pXDgq5y9b05TfvPZtLREKslBxxrwIYqJz0ruIlpRdpU8Bt0OUlNK9Ik= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=u1200SVE; arc=none smtp.client-ip=95.215.58.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="u1200SVE" Precedence: bulk X-Mailing-List: dwarves@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1744213927; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=tcsbzbZiJXvGjlam4ostG3nu+YHu98aIlt4j34i461E=; b=u1200SVEC+hJEM6LzjWRecviHM3dk1fEcB+/TRj8Nezw81pju8AR7hSB93OV1Ws5IeLc61 thdSJaCahCJ6FZkm4CldQT25AbAmo5YE9Cv5KPY71Vz3lTajz7muGqnFfH6kPkKQYPVlGS KSqJACgL8ztovzKPYCdU+ZQQwakpyuw= Date: Wed, 09 Apr 2025 15:52:03 +0000 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: "Ihor Solodrai" Message-ID: <8f5711430e4f9bb02fd06d3a5b00d46d8643fea1@linux.dev> TLS-Required: No Subject: Re: [PATCH v2 dwarves 1/2] dwarves: Add github actions to build, test To: "Alan Maguire" , acme@kernel.org Cc: yonghong.song@linux.dev, dwarves@vger.kernel.org, ast@kernel.org, andrii@kernel.org, bpf@vger.kernel.org, daniel@iogearbox.net, song@kernel.org, eddyz87@gmail.com, olsajiri@gmail.com In-Reply-To: <290e2542-fc51-402f-b84b-00e1f2ca2bfa@oracle.com> References: <20250401092435.1619617-1-alan.maguire@oracle.com> <20250401092435.1619617-2-alan.maguire@oracle.com> <880e470b221b93882250e759e4a7334b48ec88b6@linux.dev> <290e2542-fc51-402f-b84b-00e1f2ca2bfa@oracle.com> X-Migadu-Flow: FLOW_OUT On 4/9/25 1:59 AM, Alan Maguire wrote: >=20 >>>=20[...] >>> + >>> +cat tools/testing/selftests/bpf/config \ >>> + tools/testing/selftests/bpf/config.${INPUTS_ARCH} > .config >>> +# this file might or might not exist depending on kernel version >>> +if [[ -f tools/testing/selftests/bpf/config.vm ]]; then >>> + cat tools/testing/selftests/bpf/config.vm >> .config >>> +fi >>> +make olddefconfig && make prepare >>> +grep PAHOLE .config >>> +grep _BTF .config >> >> This looks like debugging code, but instead of removing it I think it >> is useful to dump entire config to the output (hence job log) in case >> something goes wrong. How about `cat .config` before make >> olddefconfig? >> > > Sounds good, but would doing it after "make olddefconfig" be more > informative maybe since some additional values may be set? I think as long as you know what is being printed it's ok. The config after olddefconfig is the full expanded config, which is quite big. > [...] > >>> diff --git a/.github/workflows/vmtest.yml b/.github/workflows/vmtest.= yml >>> new file mode 100644 >>> index 0000000..0f66eed >>> --- /dev/null >>> +++ b/.github/workflows/vmtest.yml >>> @@ -0,0 +1,62 @@ >>> +name: 'Build kernel run selftests via vmtest' >>> + >>> +on: >>> + workflow_call: >>> + inputs: >>> + runs_on: >>> + required: true >>> + default: 'ubuntu-24.04' >>> + type: string >>> + arch: >>> + description: 'what arch to test' >>> + required: true >>> + default: 'x86_64' >>> + type: string >>> + kernel: >>> + description: 'kernel version or LATEST' >>> + required: true >>> + default: 'LATEST' >>> + type: string >>> + pahole: >>> + description: 'pahole rev or branch' >>> + required: false >>> + default: 'master' >>> + type: string >>> + llvm-version: >>> + description: 'llvm version' >>> + required: false >>> + default: '18' >>> + type: string >>> +jobs: >>> + vmtest: >>> + name: pahole@${{ inputs.arch }} >>> + runs-on: ${{ inputs.runs_on }} >>> + steps: >>> + >>> + - uses: actions/checkout@v4 >>> + >>> + - name: Setup environment >>> + uses: libbpf/ci/setup-build-env@v3 >>> + with: >>> + pahole: ${{ inputs.pahole }} >>> + arch: ${{ inputs.arch }} >>> + llvm-version: ${{ inputs.llvm-version }} >> >> I think I mentioned it before, but libbpf/ci/setup-build-env checks >> out and installs pahole too, which is unnecessary here. Have you tried >> removing this step from the job? >> >> You should be able to reuse a piece of SETUP logic from >> build-debian.sh to install pahole's dependencies. Although you kernel >> build deps are needed too. >> > > Yeah it's the latter that are needed I think. > >> I could make a change in libbpf/ci/setup-build-env to accept a special >> `pahole` input value or check for env variable to NOT build pahole. >> What do you think? > > That would be great! Something like "pahole: none"? Yes, something like that. It's a small change. I'll let you know when it's done. > > I'll probably try and land this more or less as-is as we're hoping to > get 1.30 out the door this week, but definitely will follow up with > builds with shared library libbpf etc. Thanks for taking a look! > > Alan