Re: [PATCH] Avoid warning when building with NDEBUG

[Arnaldo Carvalho de Melo <acme@kernel.org>]

Em Thu, Feb 18, 2021 at 09:51:15AM -0800, Ian Rogers escreveu:
> The assert macro is compiled out with NDEBUG which can lead to an unused
> variable warning if the variable is only read in the assert. This is
> seen just here:
> 
> dwarf_loader.c:957:17: error: unused variable 'tag' [-Werror,-Wunused-variable]
>         const uint16_t tag = dwarf_tag(die);

Thanks Ian, I added:

Signed-off-by: Ian Rogers <irogers@google.com>

And CC: dwarves@vger.kernel.org

Please let me know if this is all ok.

- Arnaldo

> ---
>  dwarf_loader.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/dwarf_loader.c b/dwarf_loader.c
> index b73d786..22c3a55 100644
> --- a/dwarf_loader.c
> +++ b/dwarf_loader.c
> @@ -954,9 +954,10 @@ static struct lexblock *lexblock__new(Dwarf_Die *die, struct cu *cu)
>  
>  static void ftype__init(struct ftype *ftype, Dwarf_Die *die, struct cu *cu)
>  {
> +#ifndef NDEBUG
>  	const uint16_t tag = dwarf_tag(die);
>  	assert(tag == DW_TAG_subprogram || tag == DW_TAG_subroutine_type);
> -
> +#endif
>  	tag__init(&ftype->tag, cu, die);
>  	INIT_LIST_HEAD(&ftype->parms);
>  	ftype->nr_parms	    = 0;
> -- 
> 2.30.0.617.g56c4b15f3c-goog
> 

-- 

- Arnaldo