From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 14E31C433EF for ; Mon, 21 Mar 2022 21:08:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229825AbiCUVKL (ORCPT ); Mon, 21 Mar 2022 17:10:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47318 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229680AbiCUVKK (ORCPT ); Mon, 21 Mar 2022 17:10:10 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 49C8735AAE; Mon, 21 Mar 2022 14:08:44 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id F292EB819C7; Mon, 21 Mar 2022 21:08:42 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8BD0CC340E8; Mon, 21 Mar 2022 21:08:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1647896921; bh=9R1HG55IiLHxyMr19TMRy4BRam3sXhg+kNYxQxoAbh8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=I3x57HGCa67NtNtZwQlzlwJXxltfZ0cQgqWK3OHIlbgfsLD5YWabP/d/NrepNX0kr SrzpkMfxDcfiC/xkgm0r17emmX8TZSueJgFvslLUQTt0Qn3EgxJpN3hjrtVtkAJ8Qk /I6+yI7nMoVi3lVNiHIGxPsqypc513JyGWK9WeoTkanZXsv4WOh27Txzfx2kkJ+0AO kiBUL5TO57IxE/aS7Y6vK/LDr55UHzt2GgfTiq12Sbbr+oQYiOhQETv2mzEx0ajtEB wuRhJcHLW3wiLbbJnBYsDBpIaXDg594lprkUskWlwO1Ga81aV8ZMPNmxvpon01tQdC ICiUMsJpepk2Q== Received: by quaco.ghostprotocols.net (Postfix, from userid 1000) id 32D7F40407; Mon, 21 Mar 2022 18:08:39 -0300 (-03) Date: Mon, 21 Mar 2022 18:08:39 -0300 From: Arnaldo Carvalho de Melo To: Kui-Feng Lee Cc: Andrii Nakryiko , Daniel Borkmann , Alexei Starovoitov , Andrii Nakryiko , dwarves@vger.kernel.org, bpf@vger.kernel.org Subject: Re: [PATCH dwarves v4 1/4] dwarf_loader: Receive per-thread data on worker threads. Message-ID: References: <20220126192039.2840752-1-kuifeng@fb.com> <20220126192039.2840752-2-kuifeng@fb.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Url: http://acmel.wordpress.com Precedence: bulk List-ID: X-Mailing-List: dwarves@vger.kernel.org Em Mon, Mar 21, 2022 at 07:06:06PM +0000, Kui-Feng Lee escreveu: > On Wed, 2022-03-09 at 16:18 -0800, Andrii Nakryiko wrote: > > On Wed, Mar 9, 2022 at 4:14 PM Andrii Nakryiko wrote: > > > I did check locally with latest pahole master, and it seems like > > > something is wrong with generated BTF. I get three selftests > > > failure > > > if I use latest pahole compiled from master. > > > Kui-Feng, please take a look when you get a chance. Arnaldo, please > > > hold off from releasing a new version for now. > I just figure out the root cuase. > It caused by missing info from percpu_secinfo when collecting data from > threads. The encoder stores it separatedly from struct btf, and we > have separated different encoders for threads. They are not merged > together. I will fixed it ASAP. Cool, looking forward to the fix. - Arnaldo