From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Alan Maguire <alan.maguire@oracle.com>
Cc: Andrii Nakryiko <andrii@kernel.org>,
Eduard Zingerman <eddyz87@gmail.com>,
Ihor Solodrai <ihor.solodrai@pm.me>,
Mykola Lysenko <mykolal@fb.com>,
dwarves@vger.kernel.org
Subject: [PATCH 1/1] pfunct: Don't print functions twice when using -f
Date: Mon, 30 Dec 2024 16:36:03 -0300 [thread overview]
Message-ID: <Z3L2I_7Dzob9W0fs@x1> (raw)
We print it in the pfunct_stealer, i.e. as soon as we load the CU
containing the function information, and then, later, we were iterating
all cus and printing the functions that matched.
Do it just at the stealer.
Cc: Alan Maguire <alan.maguire@oracle.com>
Cc: Andrii Nakryiko <andrii@kernel.org>
Cc: Eduard Zingerman <eddyz87@gmail.com>
Cc: Ihor Solodrai <ihor.solodrai@pm.me>
Cc: Mykola Lysenko <mykolal@fb.com>
Link: https://lore.kernel.org/all/Z3LoTvt7PtUAbh5K@x1
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
pfunct.c | 11 ++++-------
1 file changed, 4 insertions(+), 7 deletions(-)
diff --git a/pfunct.c b/pfunct.c
index 55eafe8a8e790dcb..5a6dd59a1c7a30b1 100644
--- a/pfunct.c
+++ b/pfunct.c
@@ -415,14 +415,12 @@ static void function__show(struct function *func, struct cu *cu)
fstats->printed = true;
}
-static int cu_function_iterator(struct cu *cu, void *cookie)
+static int cu_function_iterator(struct cu *cu, void *cookie __maybe_unused)
{
struct function *function;
uint32_t id;
cu__for_each_function(cu, id, function) {
- if (cookie && strcmp(function__name(function), cookie) != 0)
- continue;
function__show(function, cu);
}
return 0;
@@ -816,10 +814,9 @@ try_sole_arg_as_function_name:
function__show(f, cu);
} else if (show_total_inline_expansion_stats)
print_total_inline_stats();
- else if (function_name != NULL || expand_types)
- cus__for_each_cu(cus, cu_function_iterator,
- function_name, NULL);
- else
+ else if (expand_types)
+ cus__for_each_cu(cus, cu_function_iterator, NULL, NULL);
+ else if (function_name == NULL)
print_fn_stats(formatter);
rc = EXIT_SUCCESS;
--
2.46.2
next reply other threads:[~2024-12-30 19:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-30 19:36 Arnaldo Carvalho de Melo [this message]
2025-01-02 23:21 ` [PATCH 1/1] pfunct: Don't print functions twice when using -f Ihor Solodrai
2025-01-09 16:02 ` Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z3L2I_7Dzob9W0fs@x1 \
--to=acme@kernel.org \
--cc=alan.maguire@oracle.com \
--cc=andrii@kernel.org \
--cc=dwarves@vger.kernel.org \
--cc=eddyz87@gmail.com \
--cc=ihor.solodrai@pm.me \
--cc=mykolal@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox