* [PATCH] Reformat a too long line.
@ 2025-02-01 14:25 Domenico Andreoli
2025-02-10 16:54 ` Alan Maguire
0 siblings, 1 reply; 3+ messages in thread
From: Domenico Andreoli @ 2025-02-01 14:25 UTC (permalink / raw)
To: dwarves
[-- Attachment #1: Type: text/plain, Size: 1897 bytes --]
From: Domenico Andreoli <domenico.andreoli@linux.com>
Reformat a too long line.
Signed-off-by: Domenico Andreoli <domenico.andreoli@linux.com>
---
man-pages/pahole.1 | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
Index: b/man-pages/pahole.1
===================================================================
--- a/man-pages/pahole.1
+++ b/man-pages/pahole.1
@@ -304,7 +304,12 @@ Allow using all the BTF features support
.TP
.B \-\-btf_features=FEATURE_LIST
-Encode BTF using the specified feature list, or specify 'default' for all standard features supported. This option can be used as an alternative to using multiple BTF-related options, and 'default' represents the standard set of BTF features that are in use for kernel BTF generation, so is useful as a shortcut for testing the latest set of standard features. However kernel builds will call out specific features rather than using 'default' to ensure that the desired features are enabled regardless of pahole version and associated 'default' set. Supported standard features are
+Encode BTF using the specified feature list, or specify 'default' for all standard features
+supported. This option can be used as an alternative to using multiple BTF-related options,
+and 'default' represents the standard set of BTF features that are in use for kernel BTF generation,
+so is useful as a shortcut for testing the latest set of standard features. However kernel builds
+will call out specific features rather than using 'default' to ensure that the desired features
+are enabled regardless of pahole version and associated 'default' set. Supported standard features are
.nf
encode_force Ignore invalid symbols when encoding BTF; for example
--
rsa4096: 3B10 0CA1 8674 ACBA B4FE FCD2 CE5B CF17 9960 DE13
ed25519: FFB4 0CC3 7F2E 091D F7DA 356E CC79 2832 ED38 CB05
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Reformat a too long line.
2025-02-01 14:25 [PATCH] Reformat a too long line Domenico Andreoli
@ 2025-02-10 16:54 ` Alan Maguire
2025-02-10 20:01 ` Domenico Andreoli
0 siblings, 1 reply; 3+ messages in thread
From: Alan Maguire @ 2025-02-10 16:54 UTC (permalink / raw)
To: Domenico Andreoli, dwarves
On 01/02/2025 14:25, Domenico Andreoli wrote:
> From: Domenico Andreoli <domenico.andreoli@linux.com>
>
> Reformat a too long line.
>
> Signed-off-by: Domenico Andreoli <domenico.andreoli@linux.com>
not sure this patch is needed; man will reformat the line for terminal
display, right?
>
> ---
> man-pages/pahole.1 | 7 ++++++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
>
> Index: b/man-pages/pahole.1
> ===================================================================
> --- a/man-pages/pahole.1
> +++ b/man-pages/pahole.1
> @@ -304,7 +304,12 @@ Allow using all the BTF features support
>
> .TP
> .B \-\-btf_features=FEATURE_LIST
> -Encode BTF using the specified feature list, or specify 'default' for all standard features supported. This option can be used as an alternative to using multiple BTF-related options, and 'default' represents the standard set of BTF features that are in use for kernel BTF generation, so is useful as a shortcut for testing the latest set of standard features. However kernel builds will call out specific features rather than using 'default' to ensure that the desired features are enabled regardless of pahole version and associated 'default' set. Supported standard features are
> +Encode BTF using the specified feature list, or specify 'default' for all standard features
> +supported. This option can be used as an alternative to using multiple BTF-related options,
> +and 'default' represents the standard set of BTF features that are in use for kernel BTF generation,
> +so is useful as a shortcut for testing the latest set of standard features. However kernel builds
> +will call out specific features rather than using 'default' to ensure that the desired features
> +are enabled regardless of pahole version and associated 'default' set. Supported standard features are
>
> .nf
> encode_force Ignore invalid symbols when encoding BTF; for example
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Reformat a too long line.
2025-02-10 16:54 ` Alan Maguire
@ 2025-02-10 20:01 ` Domenico Andreoli
0 siblings, 0 replies; 3+ messages in thread
From: Domenico Andreoli @ 2025-02-10 20:01 UTC (permalink / raw)
To: Alan Maguire; +Cc: dwarves
On Mon, Feb 10, 2025 at 04:54:17PM +0000, Alan Maguire wrote:
> On 01/02/2025 14:25, Domenico Andreoli wrote:
> > From: Domenico Andreoli <domenico.andreoli@linux.com>
> >
> > Reformat a too long line.
> >
> > Signed-off-by: Domenico Andreoli <domenico.andreoli@linux.com>
>
> not sure this patch is needed; man will reformat the line for terminal
> display, right?
yes, sure but try editing that line from a terminal.
this is purely a source code quality nit, nobody will be injuried if
you don't merge and neither will if you instead merge it :).
>
> >
> > ---
> > man-pages/pahole.1 | 7 ++++++-
> > 1 file changed, 6 insertions(+), 1 deletion(-)
> >
> > Index: b/man-pages/pahole.1
> > ===================================================================
> > --- a/man-pages/pahole.1
> > +++ b/man-pages/pahole.1
> > @@ -304,7 +304,12 @@ Allow using all the BTF features support
> >
> > .TP
> > .B \-\-btf_features=FEATURE_LIST
> > -Encode BTF using the specified feature list, or specify 'default' for all standard features supported. This option can be used as an alternative to using multiple BTF-related options, and 'default' represents the standard set of BTF features that are in use for kernel BTF generation, so is useful as a shortcut for testing the latest set of standard features. However kernel builds will call out specific features rather than using 'default' to ensure that the desired features are enabled regardless of pahole version and associated 'default' set. Supported standard features are
> > +Encode BTF using the specified feature list, or specify 'default' for all standard features
> > +supported. This option can be used as an alternative to using multiple BTF-related options,
> > +and 'default' represents the standard set of BTF features that are in use for kernel BTF generation,
> > +so is useful as a shortcut for testing the latest set of standard features. However kernel builds
> > +will call out specific features rather than using 'default' to ensure that the desired features
> > +are enabled regardless of pahole version and associated 'default' set. Supported standard features are
> >
> > .nf
> > encode_force Ignore invalid symbols when encoding BTF; for example
>
>
--
rsa4096: 3B10 0CA1 8674 ACBA B4FE FCD2 CE5B CF17 9960 DE13
ed25519: FFB4 0CC3 7F2E 091D F7DA 356E CC79 2832 ED38 CB05
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-02-10 20:01 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-02-01 14:25 [PATCH] Reformat a too long line Domenico Andreoli
2025-02-10 16:54 ` Alan Maguire
2025-02-10 20:01 ` Domenico Andreoli
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox