public inbox for dwarves@vger.kernel.org
 help / color / mirror / Atom feed
From: Domenico Andreoli <domenico.andreoli@linux.com>
To: Alan Maguire <alan.maguire@oracle.com>
Cc: dwarves@vger.kernel.org
Subject: Re: [PATCH] Reformat a too long line.
Date: Mon, 10 Feb 2025 21:01:29 +0100	[thread overview]
Message-ID: <Z6pbGaXSGpCOJ6AQ@localhost> (raw)
In-Reply-To: <80c1c334-ac68-4cf8-ab42-a93d9c8974a3@oracle.com>

On Mon, Feb 10, 2025 at 04:54:17PM +0000, Alan Maguire wrote:
> On 01/02/2025 14:25, Domenico Andreoli wrote:
> > From: Domenico Andreoli <domenico.andreoli@linux.com>
> > 
> > Reformat a too long line.
> > 
> > Signed-off-by: Domenico Andreoli <domenico.andreoli@linux.com>
> 
> not sure this patch is needed; man will reformat the line for terminal
> display, right?

yes, sure but try editing that line from a terminal.

this is purely a source code quality nit, nobody will be injuried if
you don't merge and neither will if you instead merge it :).

> 
> > 
> > ---
> >  man-pages/pahole.1 |    7 ++++++-
> >  1 file changed, 6 insertions(+), 1 deletion(-)
> > 
> > Index: b/man-pages/pahole.1
> > ===================================================================
> > --- a/man-pages/pahole.1
> > +++ b/man-pages/pahole.1
> > @@ -304,7 +304,12 @@ Allow using all the BTF features support
> >  
> >  .TP
> >  .B \-\-btf_features=FEATURE_LIST
> > -Encode BTF using the specified feature list, or specify 'default' for all standard features supported.  This option can be used as an alternative to using multiple BTF-related options, and 'default' represents the standard set of BTF features that are in use for kernel BTF generation, so is useful as a shortcut for testing the latest set of standard features.  However kernel builds will call out specific features rather than using 'default' to ensure that the desired features are enabled regardless of pahole version and associated 'default' set.  Supported standard features are
> > +Encode BTF using the specified feature list, or specify 'default' for all standard features
> > +supported.  This option can be used as an alternative to using multiple BTF-related options,
> > +and 'default' represents the standard set of BTF features that are in use for kernel BTF generation,
> > +so is useful as a shortcut for testing the latest set of standard features.  However kernel builds
> > +will call out specific features rather than using 'default' to ensure that the desired features
> > +are enabled regardless of pahole version and associated 'default' set.  Supported standard features are
> >  
> >  .nf
> >  	encode_force       Ignore invalid symbols when encoding BTF; for example
> 
> 

-- 
rsa4096: 3B10 0CA1 8674 ACBA B4FE  FCD2 CE5B CF17 9960 DE13
ed25519: FFB4 0CC3 7F2E 091D F7DA  356E CC79 2832 ED38 CB05

      reply	other threads:[~2025-02-10 20:01 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-01 14:25 [PATCH] Reformat a too long line Domenico Andreoli
2025-02-10 16:54 ` Alan Maguire
2025-02-10 20:01   ` Domenico Andreoli [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Z6pbGaXSGpCOJ6AQ@localhost \
    --to=domenico.andreoli@linux.com \
    --cc=alan.maguire@oracle.com \
    --cc=dwarves@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox