From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Jiri Olsa <olsajiri@gmail.com>
Cc: Alan Maguire <alan.maguire@oracle.com>,
dwarves@vger.kernel.org, eddyz87@gmail.com,
shung-hsi.yu@suse.com, jirislaby@kernel.org,
sedat.dilek@gmail.com, w@1wt.eu
Subject: Re: [PATCH v4 dwarves 0/2] fixes for memory optimized BTF
Date: Mon, 30 Sep 2024 11:34:40 -0300 [thread overview]
Message-ID: <Zvq3AKQGHSXfiSIR@x1> (raw)
In-Reply-To: <ZvqJawSN_UVwQdAc@krava>
On Mon, Sep 30, 2024 at 01:20:11PM +0200, Jiri Olsa wrote:
> On Mon, Sep 30, 2024 at 09:17:23AM +0100, Alan Maguire wrote:
> > This series is identical in effect to [1], it is simply applied
> > on top of the "next" branch which now includes v2 of the series.
> >
> > Patch 1 fixes issues identified in code review around use of
> > func->state, strncpy issues.
> >
> > Patch 2 speeds up the btf_functions.sh test by reducing the
> > number of greps/pipes, shaving ~1 minute off execution time.
> >
> > [1] https://lore.kernel.org/dwarves/20240925091734.1943742-1-alan.maguire@oracle.com/
> >
> > Changes since v2:
> >
> > - fixed checks of func->state since it is always non-NULL and removed
> > now-unneeded fields from dwarves.h; added assertions that either
> > ELF or DWARF data is present for func encoding (Jiri, patch 1)
>
> lgtm
>
> Acked-by: Jiri Olsa <jolsa@kernel.org>
Thanks, applied to next,
- Arnaldo
prev parent reply other threads:[~2024-09-30 14:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-30 8:17 [PATCH v4 dwarves 0/2] fixes for memory optimized BTF Alan Maguire
2024-09-30 8:17 ` [PATCH v4 dwarves 1/2] btf_encoder: fix strncpy issues, other issues identified in code review Alan Maguire
2024-09-30 8:17 ` [PATCH v4 dwarves 2/2] tests: improve btf_functions.sh by reducing greps/pipes Alan Maguire
2024-09-30 11:20 ` [PATCH v4 dwarves 0/2] fixes for memory optimized BTF Jiri Olsa
2024-09-30 14:34 ` Arnaldo Carvalho de Melo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zvq3AKQGHSXfiSIR@x1 \
--to=acme@kernel.org \
--cc=alan.maguire@oracle.com \
--cc=dwarves@vger.kernel.org \
--cc=eddyz87@gmail.com \
--cc=jirislaby@kernel.org \
--cc=olsajiri@gmail.com \
--cc=sedat.dilek@gmail.com \
--cc=shung-hsi.yu@suse.com \
--cc=w@1wt.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox