* [PATCH v2 1/1] tests reproducible_build.sh: Try first to find a vmlinux using pahole --running_kernel_vmlinux
@ 2024-10-01 19:38 Arnaldo Carvalho de Melo
2024-10-01 19:57 ` Alan Maguire
0 siblings, 1 reply; 2+ messages in thread
From: Arnaldo Carvalho de Melo @ 2024-10-01 19:38 UTC (permalink / raw)
To: Alan Maguire; +Cc: dwarves
Otherwise it stops working when called directly.
Cc: Alan Maguire <alan.maguire@oracle.com>
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
tests/reproducible_build.sh | 8 ++------
1 file changed, 2 insertions(+), 6 deletions(-)
diff --git a/tests/reproducible_build.sh b/tests/reproducible_build.sh
index a3603798a26de94c..19ef22708bbc969f 100755
--- a/tests/reproducible_build.sh
+++ b/tests/reproducible_build.sh
@@ -4,16 +4,12 @@
# Test if BTF generated serially matches reproducible parallel DWARF loading + serial BTF encoding
# Arnaldo Carvalho de Melo <acme@redhat.com> (C) 2024-
-vmlinux=${vmlinux:-1}
-
if [ -z "$vmlinux" ] ; then
vmlinux=$(pahole --running_kernel_vmlinux)
- if [ -z "$vmlinux" ] ; then
- echo "Please specify a vmlinux file to operate on"
- exit 2
- fi
fi
+vmlinux=${vmlinux:-1}
+
if [ ! -f "$vmlinux" ] ; then
echo "$vmlinux file not available, please specify another"
exit 2
--
2.46.2
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH v2 1/1] tests reproducible_build.sh: Try first to find a vmlinux using pahole --running_kernel_vmlinux
2024-10-01 19:38 [PATCH v2 1/1] tests reproducible_build.sh: Try first to find a vmlinux using pahole --running_kernel_vmlinux Arnaldo Carvalho de Melo
@ 2024-10-01 19:57 ` Alan Maguire
0 siblings, 0 replies; 2+ messages in thread
From: Alan Maguire @ 2024-10-01 19:57 UTC (permalink / raw)
To: Arnaldo Carvalho de Melo; +Cc: dwarves
On 01/10/2024 20:38, Arnaldo Carvalho de Melo wrote:
> Otherwise it stops working when called directly.
>
> Cc: Alan Maguire <alan.maguire@oracle.com>
> Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
> ---
> tests/reproducible_build.sh | 8 ++------
> 1 file changed, 2 insertions(+), 6 deletions(-)
>
> diff --git a/tests/reproducible_build.sh b/tests/reproducible_build.sh
> index a3603798a26de94c..19ef22708bbc969f 100755
> --- a/tests/reproducible_build.sh
> +++ b/tests/reproducible_build.sh
> @@ -4,16 +4,12 @@
> # Test if BTF generated serially matches reproducible parallel DWARF loading + serial BTF encoding
> # Arnaldo Carvalho de Melo <acme@redhat.com> (C) 2024-
>
> -vmlinux=${vmlinux:-1}
sorry, my bad; this line should be
vmlinux=${vmlinux:-$1}
> -
> if [ -z "$vmlinux" ] ; then
> vmlinux=$(pahole --running_kernel_vmlinux)
> - if [ -z "$vmlinux" ] ; then
> - echo "Please specify a vmlinux file to operate on"
> - exit 2
> - fi
> fi
>
> +vmlinux=${vmlinux:-1}
> +
> if [ ! -f "$vmlinux" ] ; then
> echo "$vmlinux file not available, please specify another"
> exit 2
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-10-01 19:57 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-10-01 19:38 [PATCH v2 1/1] tests reproducible_build.sh: Try first to find a vmlinux using pahole --running_kernel_vmlinux Arnaldo Carvalho de Melo
2024-10-01 19:57 ` Alan Maguire
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox