Re: [PATCH dwarves] btf_encoder: filter var names before btf name check

[Arnaldo Carvalho de Melo <acme@kernel.org>]

On Tue, Oct 22, 2024 at 08:21:09PM +0200, Miguel Ojeda wrote:
> On Fri, Oct 18, 2024 at 11:43 AM Alan Maguire <alan.maguire@oracle.com> wrote:
> >
> > ...as this means we avoid seeing multiple messages of the form
> >
> > PAHOLE: Warning: Found invalid variable name when encoding btf, ignored (sym: '__UNIQUE_ID___addressable__RNvXsa_NtCs2vSfyxKMEZc_4core4charNtB5_11EscapeDebugNtNtNtNtB7_4iter6traits10exact_size17ExactSizeIterator3len57').
> >
> > Such symbols are filtered anyway due to the __UNIQUE_ID prefix, so
> > warning about them is not necessary; simply reordering the checks
> > should ensure we will not see these warnings.
> >
> > Reported-by: Arnaldo Carvalho de Melo <acme@kernel.org>
> > Signed-off-by: Alan Maguire <alan.maguire@oracle.com>
> 
> FWIW, I applied the patch and the `__UNIQUE_ID` warnings indeed go
> away (but I don't know if those warnings would be useful to see/fix
> for other reasons):

Maybe we should have a debug mode where anything that is skipped gets
reported.
 
> Tested-by: Miguel Ojeda <ojeda@kernel.org>

Thanks, since this hasn't hit 'master' yet, I added it to the cset,

- Arnaldo