From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Stephen Brennan <stephen.s.brennan@oracle.com>
Cc: Alan Maguire <alan.maguire@oracle.com>,
ojeda@kernel.org, andrii.nakryiko@gmail.com, jolsa@kernel.org,
dwarves@vger.kernel.org
Subject: Re: [PATCH dwarves] btf_encoder: filter var names before btf name check
Date: Wed, 23 Oct 2024 11:24:59 -0300 [thread overview]
Message-ID: <ZxkHOybaXSWYo6Mq@x1> (raw)
In-Reply-To: <87v7xjrdei.fsf@oracle.com>
On Tue, Oct 22, 2024 at 03:17:09PM -0700, Stephen Brennan wrote:
> Alan Maguire <alan.maguire@oracle.com> writes:
> > ...as this means we avoid seeing multiple messages of the form
> > PAHOLE: Warning: Found invalid variable name when encoding btf, ignored (sym: '__UNIQUE_ID___addressable__RNvXsa_NtCs2vSfyxKMEZc_4core4charNtB5_11EscapeDebugNtNtNtNtB7_4iter6traits10exact_size17ExactSizeIterator3len57').
>
> a beautiful variable name :P
A unique one :-)
> > Such symbols are filtered anyway due to the __UNIQUE_ID prefix, so
> > warning about them is not necessary; simply reordering the checks
> > should ensure we will not see these warnings.
> > Reported-by: Arnaldo Carvalho de Melo <acme@kernel.org>
> > Signed-off-by: Alan Maguire <alan.maguire@oracle.com>
> Sorry I'm late to review. This is a good catch and is clearly correct
> to me.
Thanks, since it hasn't moved to master, I'm adding it.
> Reviewed-by: Stephen Brennan <stephen.s.brennan@oracle.com>
- Arnaldo
prev parent reply other threads:[~2024-10-23 14:25 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-18 9:43 [PATCH dwarves] btf_encoder: filter var names before btf name check Alan Maguire
2024-10-22 18:21 ` Miguel Ojeda
2024-10-22 18:39 ` Arnaldo Carvalho de Melo
2024-10-22 22:17 ` Stephen Brennan
2024-10-23 14:24 ` Arnaldo Carvalho de Melo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZxkHOybaXSWYo6Mq@x1 \
--to=acme@kernel.org \
--cc=alan.maguire@oracle.com \
--cc=andrii.nakryiko@gmail.com \
--cc=dwarves@vger.kernel.org \
--cc=jolsa@kernel.org \
--cc=ojeda@kernel.org \
--cc=stephen.s.brennan@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox