Re: [PATCH 5/5] core, libctf: Check if constructor arguments are NULL before using them

Arnaldo Carvalho de Melo
2024-11-19T18:29:14Z

On Tue, Nov 19, 2024 at 05:02:39PM +0000, Alan Maguire wrote:
> On 18/11/2024 20:41, Arnaldo Carvalho de Melo wrote:
> > From: Arnaldo Carvalho de Melo <acme@redhat.com>
> >
> > # pahole
> > Segmentation fault (core dumped)
> > #
> >
> > Now we have:
> >
> > # ls -la bla
> > ls: cannot access 'bla': No such file or directory
> > # export PAHOLE_VMLINUX_BTF_FILENAME=bla
> > # pahole
> > pahole: couldn't find any debug information on this system.
> > # pahole list_head
> > pahole: couldn't find any debug information on this system.
> > # pahole -F btf list_head
> > pahole: couldn't find any btf debug information on this system.
> > # pahole -F dwarf list_head
> > pahole: couldn't find any dwarf debug information on this system.
> > # tests/default_vmlinux_btf.sh
> > Default BTF on a system without BTF: Ok
> > #
> >
> > Reported-by: Matthias Schwarzott <zzam@gentoo.org>
> > Cc: Alan Maguire <alan.maguire@oracle.com>
> > Cc: Andrii Nakryiko <andrii@kernel.org>
> > Cc: Eduard Zingerman <eddyz87@gmail.com>
> > Cc: Jiri Olsa <jolsa@kernel.org>
> > Cc: Song Liu <song@kernel.org>
> > Cc: Yonghong Song <yonghong.song@linux.dev>
> > Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
>
> Reviewed-by: Alan Maguire <alan.maguire@oracle.com>
> Tested-by: Alan Maguire <alan.maguire@oracle.com>

Thanks, added to the cset,

- Arnaldo