Re: pahole: Fix deprecated cmake_minimum_required

[Arnaldo Carvalho de Melo <acme@kernel.org>]

On Tue, Oct 28, 2025 at 07:58:17AM +0100, Matthias Schwarzott wrote:
> I got to know that using a cmake_minimum_required version of less than 3.10
> is deprecated. Support for it will be removed from cmake.

Support for what? For features present before 3.10? So we better make
sure that we have pahole use that 'cmake_minimum_required(3.10)' so that
we don't end up using such deprecated cmake features and end up breaking
the build in distros using, say, cmake 3.11?

Please CC dwarves@vger.kernel.org when sending patches, like I did in
this reply :-)

Thanks!

- Arnaldo
 
> I suggest to raise the minimum required cmake version to at least 3.10
> (released 20 November 2017).
> See attached patch.

> see gentoo pahole issue: https://bugs.gentoo.org/964482
> gentoo overall issue: https://bugs.gentoo.org/964405
 
> cmake merge request:
> https://gitlab.kitware.com/cmake/cmake/-/merge_requests/9875
 
> deprecate-pre-3.10
> ------------------
 
> * Compatibility with versions of CMake older than 3.10 is now deprecated
>   and will be removed from a future version.  Calls to
>   :command:`cmake_minimum_required` or :command:`cmake_policy` that set
>   the policy version to an older value now issue a deprecation diagnostic.

> From b9e521ef5e9c01d8d19f505de778ceaef5ecd4eb Mon Sep 17 00:00:00 2001
> From: Matthias Schwarzott <zzam@gentoo.org>
> Date: Tue, 28 Oct 2025 07:52:00 +0100
> Subject: [PATCH] CMakeLists.txt: Require cmake 3.10 or higher
> 
> To fix this warning from cmake:
> 
> CMake Deprecation Warning at CMakeLists.txt:1 (cmake_minimum_required):
>   Compatibility with CMake < 3.10 will be removed from a future version of
>   CMake.
> 
>   Update the VERSION argument <min> value.  Or, use the <min>...<max> syntax
>   to tell CMake that the project requires at least <min> but has been updated
>   to work with policies introduced by <max> or earlier.
> 
> Signed-off-by: Matthias Schwarzott <zzam@gentoo.org>
> ---
>  CMakeLists.txt | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/CMakeLists.txt b/CMakeLists.txt
> index eb873000d7bf..91522c1382a5 100644
> --- a/CMakeLists.txt
> +++ b/CMakeLists.txt
> @@ -1,4 +1,4 @@
> -cmake_minimum_required(VERSION 3.5)
> +cmake_minimum_required(VERSION 3.10)
>  project(pahole C)
>  cmake_policy(SET CMP0005 NEW)
>  
> -- 
> 2.51.0
>