public inbox for dwarves@vger.kernel.org
 help / color / mirror / Atom feed
From: Nicolas Schier <nsc@kernel.org>
To: Ihor Solodrai <ihor.solodrai@linux.dev>
Cc: Alexei Starovoitov <ast@kernel.org>,
	Daniel Borkmann <daniel@iogearbox.net>,
	Andrii Nakryiko <andrii@kernel.org>,
	Martin KaFai Lau <martin.lau@linux.dev>,
	Eduard Zingerman <eddyz87@gmail.com>, Song Liu <song@kernel.org>,
	Yonghong Song <yonghong.song@linux.dev>,
	John Fastabend <john.fastabend@gmail.com>,
	KP Singh <kpsingh@kernel.org>,
	Stanislav Fomichev <sdf@fomichev.me>, Hao Luo <haoluo@google.com>,
	Jiri Olsa <jolsa@kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Nathan Chancellor <nathan@kernel.org>,
	Jonathan Corbet <corbet@lwn.net>, Tejun Heo <tj@kernel.org>,
	David Vernet <void@manifault.com>,
	Andrea Righi <arighi@nvidia.com>,
	Changwoo Min <changwoo@igalia.com>, Shuah Khan <shuah@kernel.org>,
	Nick Desaulniers <nick.desaulniers+lkml@gmail.com>,
	Bill Wendling <morbo@google.com>,
	Justin Stitt <justinstitt@google.com>,
	Alan Maguire <alan.maguire@oracle.com>,
	Donglin Peng <dolinux.peng@gmail.com>,
	bpf@vger.kernel.org, dwarves@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-kbuild@vger.kernel.org,
	sched-ext@lists.linux.dev
Subject: Re: [PATCH bpf-next v6 6/8] lib/Kconfig.debug: Set the minimum required pahole version to v1.22
Date: Fri, 19 Dec 2025 08:54:50 +0100	[thread overview]
Message-ID: <aUUEyncduBLl8k4n@derry.ads.avm.de> (raw)
In-Reply-To: <20251219020006.785065-7-ihor.solodrai@linux.dev>

On Thu, Dec 18, 2025 at 06:00:04PM -0800, Ihor Solodrai wrote:
> Subsequent patches in the series change vmlinux linking scripts to
> unconditionally pass --btf_encode_detached to pahole, which was
> introduced in v1.22 [1][2].
> 
> This change allows to remove PAHOLE_HAS_SPLIT_BTF Kconfig option and
> other checks of older pahole versions.
> 
> [1] https://github.com/acmel/dwarves/releases/tag/v1.22
> [2] https://lore.kernel.org/bpf/cbafbf4e-9073-4383-8ee6-1353f9e5869c@oracle.com/
> 
> Acked-by: Eduard Zingerman <eddyz87@gmail.com>
> Signed-off-by: Ihor Solodrai <ihor.solodrai@linux.dev>
> ---
>  Documentation/scheduler/sched-ext.rst |  1 -
>  lib/Kconfig.debug                     | 13 ++++---------
>  scripts/Makefile.btf                  |  9 +--------
>  tools/sched_ext/README.md             |  1 -
>  4 files changed, 5 insertions(+), 19 deletions(-)
> 
> diff --git a/Documentation/scheduler/sched-ext.rst b/Documentation/scheduler/sched-ext.rst
> index 404fe6126a76..9e2882d937b4 100644
> --- a/Documentation/scheduler/sched-ext.rst
> +++ b/Documentation/scheduler/sched-ext.rst
> @@ -43,7 +43,6 @@ options should be enabled to use sched_ext:
>      CONFIG_DEBUG_INFO_BTF=y
>      CONFIG_BPF_JIT_ALWAYS_ON=y
>      CONFIG_BPF_JIT_DEFAULT_ON=y
> -    CONFIG_PAHOLE_HAS_SPLIT_BTF=y
>      CONFIG_PAHOLE_HAS_BTF_TAG=y
>  
>  sched_ext is used only when the BPF scheduler is loaded and running.
> diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug
> index ba36939fda79..60281c4f9e99 100644
> --- a/lib/Kconfig.debug
> +++ b/lib/Kconfig.debug
> @@ -388,18 +388,13 @@ config DEBUG_INFO_BTF
>  	depends on !DEBUG_INFO_SPLIT && !DEBUG_INFO_REDUCED
>  	depends on !GCC_PLUGIN_RANDSTRUCT || COMPILE_TEST
>  	depends on BPF_SYSCALL
> -	depends on PAHOLE_VERSION >= 116
> -	depends on DEBUG_INFO_DWARF4 || PAHOLE_VERSION >= 121
> +	depends on PAHOLE_VERSION >= 122

As CONFIG_DEBUG_INFO_BTF was the reason for 'pahole' being listed in
Documentation/process/changes.rst, does it make sense to update the
minimum pahole version there, too?

Acked-by: Nicolas Schier <nsc@kernel.org>

  reply	other threads:[~2025-12-19  7:55 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-12-19  1:59 [PATCH bpf-next v6 0/8] resolve_btfids: Support for BTF modifications Ihor Solodrai
2025-12-19  1:59 ` [PATCH bpf-next v6 1/8] resolve_btfids: Rename object btf field to btf_path Ihor Solodrai
2025-12-19  2:00 ` [PATCH bpf-next v6 2/8] resolve_btfids: Factor out load_btf() Ihor Solodrai
2025-12-19  2:00 ` [PATCH bpf-next v6 3/8] resolve_btfids: Introduce enum btf_id_kind Ihor Solodrai
2025-12-19  2:00 ` [PATCH bpf-next v6 4/8] resolve_btfids: Always build with -Wall -Werror Ihor Solodrai
2025-12-19  2:00 ` [PATCH bpf-next v6 5/8] kbuild: Sync kconfig when PAHOLE_VERSION changes Ihor Solodrai
2025-12-19  7:49   ` Nicolas Schier
2025-12-19  2:00 ` [PATCH bpf-next v6 6/8] lib/Kconfig.debug: Set the minimum required pahole version to v1.22 Ihor Solodrai
2025-12-19  7:54   ` Nicolas Schier [this message]
2025-12-19  2:00 ` [PATCH bpf-next v6 7/8] selftests/bpf: Run resolve_btfids only for relevant .test.o objects Ihor Solodrai
2025-12-19  2:00 ` [PATCH bpf-next v6 8/8] resolve_btfids: Change in-place update with raw binary output Ihor Solodrai
2025-12-19 13:00 ` [PATCH bpf-next v6 0/8] resolve_btfids: Support for BTF modifications Alan Maguire

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aUUEyncduBLl8k4n@derry.ads.avm.de \
    --to=nsc@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=alan.maguire@oracle.com \
    --cc=andrii@kernel.org \
    --cc=arighi@nvidia.com \
    --cc=ast@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=changwoo@igalia.com \
    --cc=corbet@lwn.net \
    --cc=daniel@iogearbox.net \
    --cc=dolinux.peng@gmail.com \
    --cc=dwarves@vger.kernel.org \
    --cc=eddyz87@gmail.com \
    --cc=haoluo@google.com \
    --cc=ihor.solodrai@linux.dev \
    --cc=john.fastabend@gmail.com \
    --cc=jolsa@kernel.org \
    --cc=justinstitt@google.com \
    --cc=kpsingh@kernel.org \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=martin.lau@linux.dev \
    --cc=morbo@google.com \
    --cc=nathan@kernel.org \
    --cc=nick.desaulniers+lkml@gmail.com \
    --cc=sched-ext@lists.linux.dev \
    --cc=sdf@fomichev.me \
    --cc=shuah@kernel.org \
    --cc=song@kernel.org \
    --cc=tj@kernel.org \
    --cc=void@manifault.com \
    --cc=yonghong.song@linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox