Re: [PATCH bpf-next] bpf, docs: Update pahole to 1.28 for selftests

[Bagas Sanjaya <bagasdotme@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1352 bytes --]

On Fri, Jan 02, 2026 at 07:33:50AM -0800, Ihor Solodrai wrote:
> On 1/2/26 3:13 AM, Hemanth Malla wrote:
> > diff --git a/Documentation/bpf/bpf_devel_QA.rst b/Documentation/bpf/bpf_devel_QA.rst
> > index 0acb4c9b8d90..3a147b6c780e 100644
> > --- a/Documentation/bpf/bpf_devel_QA.rst
> > +++ b/Documentation/bpf/bpf_devel_QA.rst
> > @@ -482,7 +482,7 @@ under test should match the config file fragment in
> >  tools/testing/selftests/bpf as closely as possible.
> >  
> >  Finally to ensure support for latest BPF Type Format features -
> > -discussed in Documentation/bpf/btf.rst - pahole version 1.16
> > +discussed in Documentation/bpf/btf.rst - pahole version 1.28
> 
> Hi Hemanth, thanks for the patch.
> 
> Acked-by: Ihor Solodrai <ihor.solodrai@linux.dev>
> 
> 1.28 is needed for --distilled_base [1], which is only a requirement
> for tests using modules. Many other tests are likely to work with
> older versions, but the minimum for the kernel build is 1.22 now [2].
> 
> Not sure if it's worth it to add this nuance to the QA doc, although
> in general we should recommend people running the selftests to use the
> latest pahole release. Maybe add a comment?

I guess minimum pahole version can be added to
Documentation/process/changes.rst.

Thanks.

-- 
An old man doll... just what I always wanted! - Clara

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]