From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Aditya Dutt <duttaditya18@gmail.com>
Cc: dwarves@vger.kernel.org, Alan Maguire <alan.maguire@oracle.com>
Subject: Re: [PATCH dwarves 0/2] pahole: Fix -C -T segfault
Date: Thu, 3 Sep 2026 22:33:42 -0300 [thread overview]
Message-ID: <apof9qe3rmRECtUG@x2> (raw)
In-Reply-To: <20260903205659.1543175-1-duttaditya18@gmail.com>
On Fri, Sep 04, 2026 at 02:26:57AM +0530, Aditya Dutt wrote:
> 'formatter' is NULL when -T is given and the -C path calls it, which
> segfaults.
> Patch 2 rejects that, like '-m -C' already does.
> Patch 1 fixes the '-m -C' error, which names '--class' incorrectly.
>
> -T has set 'formatter' to NULL since commit 286c7740fd98c4df but -C did
> not call formatter until f5857bd34b220a64 (used to call tag__fprintf
> before), so added Fixes tag referencing it.
>
> I think support for the combinations '-T -C' and '-m -C' could be added
> in the future.
>
> Problem with doing that right now is that the counting logic lives in
> the 'class_name == NULL' block that -C skips. And -C stops loading CUs
> once all classes are found.
Thanks, applied, I'll now stop processing patches and release 1.32
tomorrow.
- Arnaldo
prev parent reply other threads:[~2026-09-04 1:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-03 20:56 [PATCH dwarves 0/2] pahole: Fix -C -T segfault Aditya Dutt
2026-09-03 20:56 ` [PATCH dwarves 1/2] pahole: Fix option name in the -m/-C error message Aditya Dutt
2026-09-03 20:56 ` [PATCH dwarves 2/2] pahole: Fix -C -T segfault Aditya Dutt
2026-09-04 1:33 ` Arnaldo Carvalho de Melo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=apof9qe3rmRECtUG@x2 \
--to=acme@kernel.org \
--cc=alan.maguire@oracle.com \
--cc=duttaditya18@gmail.com \
--cc=dwarves@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox