Dwarves debugging tools
 help / color / mirror / Atom feed
From: Yonghong Song <yonghong.song@linux.dev>
To: Jiri Olsa <olsajiri@gmail.com>, Alan Maguire <alan.maguire@oracle.com>
Cc: Arnaldo Carvalho de Melo <arnaldo.melo@gmail.com>,
	dwarves@vger.kernel.org, Alexei Starovoitov <ast@kernel.org>,
	Andrii Nakryiko <andrii@kernel.org>,
	bpf@vger.kernel.org, kernel-team@fb.com
Subject: Re: [PATCH dwarves v7 0/5] pahole: Encode true signatures in kernel BTF
Date: Wed, 24 Jun 2026 06:52:54 -0700	[thread overview]
Message-ID: <d520bda3-4eca-4ea6-b423-990935a0d3c8@linux.dev> (raw)
In-Reply-To: <ajujJM9N0_QpB_3d@krava>



On 6/24/26 2:28 AM, Jiri Olsa wrote:
> On Tue, Jun 23, 2026 at 05:02:30PM +0100, Alan Maguire wrote:
>
> SNIP
>
>>>> hi,
>>>> I tried to get the numbers from my setup and noticed that some new
>>>> functions were included in BTF compared to the current version
>>>> (functions diff attached below)
>>>>
>>>> like for "arp_process" function the current pahole gives me:
>>>>
>>>>    arp_process : skipping BTF encoding of function due to unexpected register usage for parameter
>>>>
>>>> but it's included in BTF generated with the new pahole.
>>>>
>>>> in addition to your explanation above also one of the commit says:
>>>>
>>>>       - a parameter with no location, a constant value, or (for non-clang) no
>>>>         register found is marked optimized out
>>>>
>>>> please check below, it seems like 2nd argument of arp_process has no location,
>>>> so iiuc it should not be included in BTF, right?
>>>>
>>>> thanks,
>>>> jirka
>>>>
>>>>
>>> thanks for catching this; it looks like we return a bit early before detecting
>>> missing locations in the non-true-signature code. If you get a chance, would you
>>> mind trying the attached patch to see if it fixes the problem?
>>>
>>> If the fix works and Yonghong is happy with it we can add it as a followup
>>> and land the true signature series to save another round.
>> actually sorry that patch leaked true signature partial names for gcc; updated
>> patch attached.
> hum, I can't apply either of them, but I see that change on top of:
>    alan-maguire/dwarves-true-sig-v7
>
> but on that branch I can still see arp_process function in the btf
>
> please let me know if I should try some other branch

Jiri,

Please take a look at v9: https://lore.kernel.org/bpf/20260624052553.3139112-1-yonghong.song@linux.dev/

It has version 7 plus Alan's changes in version 7 comments. I forther added a
few changes related to llvm and another patch to resolve some inconsistency.

Thanks!

Yonghong

>
> thanks,
> jirka


      reply	other threads:[~2026-06-24 13:53 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-23  4:07 [PATCH dwarves v7 0/5] pahole: Encode true signatures in kernel BTF Yonghong Song
2026-06-23  4:07 ` [PATCH dwarves v7 1/5] dwarf_loader: Detect aggregate ABI register usage and signature changes Yonghong Song
2026-06-23  4:07 ` [PATCH dwarves v7 2/5] dwarf_loader: Collect per-parameter information Yonghong Song
2026-06-23  4:07 ` [PATCH dwarves v7 3/5] dwarf_loader: Analyze per-parameter information for true signatures Yonghong Song
2026-06-23  4:07 ` [PATCH dwarves v7 4/5] btf_encoder: Emit true function signatures Yonghong Song
2026-06-23  4:07 ` [PATCH dwarves v7 5/5] tests: Add BTF true_signature encoding tests Yonghong Song
2026-06-23 12:28 ` [PATCH dwarves v7 0/5] pahole: Encode true signatures in kernel BTF Jiri Olsa
2026-06-23 13:11   ` Alan Maguire
2026-06-23 16:02     ` Alan Maguire
2026-06-23 16:49       ` Yonghong Song
2026-06-23 16:58       ` Yonghong Song
2026-06-24  9:28       ` Jiri Olsa
2026-06-24 13:52         ` Yonghong Song [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d520bda3-4eca-4ea6-b423-990935a0d3c8@linux.dev \
    --to=yonghong.song@linux.dev \
    --cc=alan.maguire@oracle.com \
    --cc=andrii@kernel.org \
    --cc=arnaldo.melo@gmail.com \
    --cc=ast@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=dwarves@vger.kernel.org \
    --cc=kernel-team@fb.com \
    --cc=olsajiri@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox