From: Joe Perches <joe@perches.com>
To: Himangi Saraogi <himangi774@gmail.com>
Cc: Tyler Hicks <tyhicks@canonical.com>,
ecryptfs@vger.kernel.org, linux-kernel@vger.kernel.org,
julia.lawall@lip6.fr
Subject: Re: [PATCH] ecryptfs: Drop cast
Date: Thu, 26 Jun 2014 11:58:53 -0700 [thread overview]
Message-ID: <1403809133.7977.63.camel@joe-AO725> (raw)
In-Reply-To: <20140626184233.GA4275@himangi-Dell>
On Fri, 2014-06-27 at 00:12 +0530, Himangi Saraogi wrote:
> This patch does away with casts on void * as they are unnecessary.
[]
> diff --git a/fs/ecryptfs/inode.c b/fs/ecryptfs/inode.c
[]
> @@ -53,7 +53,7 @@ static void unlock_dir(struct dentry *dir)
>
> static int ecryptfs_inode_test(struct inode *inode, void *lower_inode)
> {
> - if (ecryptfs_inode_to_lower(inode) == (struct inode *)lower_inode)
> + if (ecryptfs_inode_to_lower(inode) == lower_inode)
> return 1;
> return 0;
> }
True, but perhaps this should be
{
return ecryptfs_inode_to_lower(inode) == lower_inode;
}
prev parent reply other threads:[~2014-06-26 18:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-26 18:42 [PATCH] ecryptfs: Drop cast Himangi Saraogi
2014-06-26 18:58 ` Joe Perches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1403809133.7977.63.camel@joe-AO725 \
--to=joe@perches.com \
--cc=ecryptfs@vger.kernel.org \
--cc=himangi774@gmail.com \
--cc=julia.lawall@lip6.fr \
--cc=linux-kernel@vger.kernel.org \
--cc=tyhicks@canonical.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox