EcryptFS development
 help / color / mirror / Atom feed
From: Tyler Hicks <tyhicks@canonical.com>
To: Jarkko Sakkinen <jarkko.sakkinen@iki.fi>
Cc: ecryptfs@vger.kernel.org
Subject: Re: async crashes
Date: Fri, 5 Apr 2013 16:52:58 -0700	[thread overview]
Message-ID: <20130405235258.GA11632@boyd> (raw)
In-Reply-To: <1364651830.2286.140661211073081.738964DE@webmail.messagingengine.com>

[-- Attachment #1: Type: text/plain, Size: 1218 bytes --]

On 2013-03-30 15:57:10, Jarkko Sakkinen wrote:
> Hi
> 
> I've been experimenting with async branch of ecryptfs for some
> workloads. Sometimes it crashes so that ecryptfs_encrypt_extent_done()
> first reports -EINPROGRESS (-115) to kernel log. After that it crashes
> in ablkcipher_walk_phys().

Were you building with Zeev's patch titled "eCryptfs: ablkcipher support
- add workqueue"? A (temporary) link to the patch can be found here:

http://git.kernel.org/cgit/linux/kernel/git/tyhicks/ecryptfs.git/commit/?h=async

Do you have a way to reproduce this? Any exotic hardware? Any crypto
acceleration hardware?

> I looked at ecryptfs_encrypt_extent_done() and this made me think
> whether it should have special case for having -EBUSY and -EINPROGRESS.

Looking at other ablkcipher callbacks, I'd think we'd at least need a
special case for -EINPROGRESS.

> 
> Sorry about bit coares "bug report" but I'm not expert either with
> ecryptfs or crypto implementation.

No problem, thanks for bringing it to our attention!


Additionally, I just cc'ed you on a different patch that I have been
working as an alternative to the async patch. Maybe you can give it a
try, as well.

Tyler

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

  reply	other threads:[~2013-04-05 23:53 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-30 13:57 async crashes Jarkko Sakkinen
2013-04-05 23:52 ` Tyler Hicks [this message]
2013-04-18 20:45   ` Jarkko Sakkinen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130405235258.GA11632@boyd \
    --to=tyhicks@canonical.com \
    --cc=ecryptfs@vger.kernel.org \
    --cc=jarkko.sakkinen@iki.fi \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox