From: Tyler Hicks <tyhicks@canonical.com>
To: Julia Lawall <julia.lawall@lip6.fr>
Cc: sergey.senozhatsky@gmail.com, kernel-janitors@vger.kernel.org,
ecryptfs@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 28/39] ecryptfs: drop null test before destroy functions
Date: Tue, 15 Sep 2015 09:45:35 -0500 [thread overview]
Message-ID: <20150915144535.GB3665@boyd> (raw)
In-Reply-To: <alpine.DEB.2.02.1509150636260.2048@localhost6.localdomain6>
[-- Attachment #1: Type: text/plain, Size: 1810 bytes --]
On 2015-09-15 06:36:30, Julia Lawall wrote:
>
>
> On Mon, 14 Sep 2015, Tyler Hicks wrote:
>
> > On 2015-09-13 14:15:21, Julia Lawall wrote:
> > > Remove unneeded NULL test.
> > >
> > > The semantic patch that makes this change is as follows:
> > > (http://coccinelle.lip6.fr/)
> > >
> > > // <smpl>
> > > @@ expression x; @@
> > > -if (x != NULL)
> > > \(kmem_cache_destroy\|mempool_destroy\|dma_pool_destroy\)(x);
> > > // </smpl>
> > >
> > > Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
> >
> > Acked-by: Tyler Hicks <tyhicks@canonical.com>
> >
> > I assume that you'll be landing this patch set into Linus' tree all
> > together. Let me know if that's incorrect and I should take this single
> > patch into the eCryptfs dev tree.
>
> I'm not doing anythign after this point. Some others have taken the patch
> into their trees.
I've taken it into my tree. Thanks again.
Tyler
>
> julia
>
> >
> > Thanks!
> >
> > Tyler
> >
> > >
> > > ---
> > > fs/ecryptfs/main.c | 3 +--
> > > 1 file changed, 1 insertion(+), 2 deletions(-)
> > >
> > > diff --git a/fs/ecryptfs/main.c b/fs/ecryptfs/main.c
> > > index 4f4d047..e83f31c 100644
> > > --- a/fs/ecryptfs/main.c
> > > +++ b/fs/ecryptfs/main.c
> > > @@ -737,8 +737,7 @@ static void ecryptfs_free_kmem_caches(void)
> > > struct ecryptfs_cache_info *info;
> > >
> > > info = &ecryptfs_cache_infos[i];
> > > - if (*(info->cache))
> > > - kmem_cache_destroy(*(info->cache));
> > > + kmem_cache_destroy(*(info->cache));
> > > }
> > > }
> > >
> > >
> >
> --
> To unsubscribe from this list: send the line "unsubscribe ecryptfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2015-09-15 14:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-13 12:14 [PATCH 00/39] drop null test before destroy functions Julia Lawall
2015-09-13 12:15 ` [PATCH 28/39] ecryptfs: " Julia Lawall
2015-09-15 2:08 ` Tyler Hicks
2015-09-15 4:36 ` Julia Lawall
2015-09-15 14:45 ` Tyler Hicks [this message]
2015-09-14 11:55 ` [PATCH 00/39] " SF Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150915144535.GB3665@boyd \
--to=tyhicks@canonical.com \
--cc=ecryptfs@vger.kernel.org \
--cc=julia.lawall@lip6.fr \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sergey.senozhatsky@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).