* [PATCH] eCryptfs: add a semicolon
@ 2020-11-27 16:05 trix
2020-11-27 18:11 ` Joe Perches
0 siblings, 1 reply; 3+ messages in thread
From: trix @ 2020-11-27 16:05 UTC (permalink / raw)
To: code, hannes, mhocko, longman, herbert, ebiggers
Cc: ecryptfs, linux-kernel, Tom Rix
From: Tom Rix <trix@redhat.com>
Function like macros should have a semicolon.
Signed-off-by: Tom Rix <trix@redhat.com>
---
fs/ecryptfs/keystore.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/ecryptfs/keystore.c b/fs/ecryptfs/keystore.c
index f6a17d259db7..2abd219cfeec 100644
--- a/fs/ecryptfs/keystore.c
+++ b/fs/ecryptfs/keystore.c
@@ -1172,7 +1172,7 @@ decrypt_pki_encrypted_session_key(struct ecryptfs_auth_tok *auth_tok,
rc = ecryptfs_cipher_code_to_string(crypt_stat->cipher, cipher_code);
if (rc) {
ecryptfs_printk(KERN_ERR, "Cipher code [%d] is invalid\n",
- cipher_code)
+ cipher_code);
goto out;
}
crypt_stat->flags |= ECRYPTFS_KEY_VALID;
--
2.18.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] eCryptfs: add a semicolon
2020-11-27 16:05 [PATCH] eCryptfs: add a semicolon trix
@ 2020-11-27 18:11 ` Joe Perches
2021-01-30 17:57 ` Tyler Hicks
0 siblings, 1 reply; 3+ messages in thread
From: Joe Perches @ 2020-11-27 18:11 UTC (permalink / raw)
To: trix, code, hannes, mhocko, longman, herbert, ebiggers
Cc: ecryptfs, linux-kernel
On Fri, 2020-11-27 at 08:05 -0800, trix@redhat.com wrote:
> Function like macros should have a semicolon.
[]
> diff --git a/fs/ecryptfs/keystore.c b/fs/ecryptfs/keystore.c
[]
> @@ -1172,7 +1172,7 @@ decrypt_pki_encrypted_session_key(struct ecryptfs_auth_tok *auth_tok,
> rc = ecryptfs_cipher_code_to_string(crypt_stat->cipher, cipher_code);
> if (rc) {
> ecryptfs_printk(KERN_ERR, "Cipher code [%d] is invalid\n",
> - cipher_code)
> + cipher_code);
As this is the only use that does not have a semicolon,
it'd be good to add the removal of the semicolon from
the #define at the same time.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] eCryptfs: add a semicolon
2020-11-27 18:11 ` Joe Perches
@ 2021-01-30 17:57 ` Tyler Hicks
0 siblings, 0 replies; 3+ messages in thread
From: Tyler Hicks @ 2021-01-30 17:57 UTC (permalink / raw)
To: Joe Perches
Cc: trix, hannes, mhocko, longman, herbert, ebiggers, ecryptfs,
linux-kernel
On 2020-11-27 10:11:23, Joe Perches wrote:
> On Fri, 2020-11-27 at 08:05 -0800, trix@redhat.com wrote:
> > Function like macros should have a semicolon.
> []
> > diff --git a/fs/ecryptfs/keystore.c b/fs/ecryptfs/keystore.c
> []
> > @@ -1172,7 +1172,7 @@ decrypt_pki_encrypted_session_key(struct ecryptfs_auth_tok *auth_tok,
> > rc = ecryptfs_cipher_code_to_string(crypt_stat->cipher, cipher_code);
> > if (rc) {
> > ecryptfs_printk(KERN_ERR, "Cipher code [%d] is invalid\n",
> > - cipher_code)
> > + cipher_code);
>
> As this is the only use that does not have a semicolon,
> it'd be good to add the removal of the semicolon from
> the #define at the same time.
I double checked that this is the only ecryptfs_printk() usage missing
the trailing semicolon and then made Joe's suggested change before
pushing the patch to the eCryptfs next branch:
https://git.kernel.org/pub/scm/linux/kernel/git/tyhicks/ecryptfs.git/log/?h=next
Thanks for the cleanup!
Tyler
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-01-30 17:58 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-11-27 16:05 [PATCH] eCryptfs: add a semicolon trix
2020-11-27 18:11 ` Joe Perches
2021-01-30 17:57 ` Tyler Hicks
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox