From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [PATCH 3/3] mm: require ->set_page_dirty to be explicitly wire up Date: Mon, 21 Jun 2021 07:26:12 +0200 Message-ID: <20210621052612.GA4064@lst.de> References: <20210614061512.3966143-1-hch@lst.de> <20210614061512.3966143-4-hch@lst.de> Mime-Version: 1.0 Return-path: Received: from verein.lst.de ([213.95.11.211]:40524 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229486AbhFUF23 (ORCPT ); Mon, 21 Jun 2021 01:28:29 -0400 Content-Disposition: inline In-Reply-To: List-ID: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Dmitry Osipenko , Tyler Hicks Cc: Christoph Hellwig , Andrew Morton , Jan Kara , Al Viro , Greg Kroah-Hartman , linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, ecryptfs@vger.kernel.org On Fri, Jun 18, 2021 at 10:23:55PM +0300, Dmitry Osipenko wrote: > > 21 files changed, 29 insertions(+), 14 deletions(-) > > The ecryptfs is now crashing with NULL deference, please fix. Which means it crashed the same before on configs without CONFIG_BLOCK. Tyler, can you look at what ecryptfs should do for ->set_page_dirty? Currently it implicitly gets __set_page_dirty_buffers for kernels with COFIG_BLOCK set, but given that this function looks at buffer_heads that ecryptfs doesn't use it can't really be the right choice. __set_page_dirty_nobuffers will probably work, but I'd love to see an audit of the page dirtying and writeback for ecryptfs while we're at it.