[PATCH 1/2] ecryptfs: Fix typo in ecryptfs_derive_iv function comment

[PATCH 1/2] ecryptfs: Fix typo in ecryptfs_derive_iv function comment

[Thorsten Blum]

s/vale/value/

Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
---
 fs/ecryptfs/crypto.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/ecryptfs/crypto.c b/fs/ecryptfs/crypto.c
index 3b59346d68c5..585bad6577ed 100644
--- a/fs/ecryptfs/crypto.c
+++ b/fs/ecryptfs/crypto.c
@@ -72,7 +72,7 @@ static int ecryptfs_crypto_api_algify_cipher_name(char **algified_name,
 
 /**
  * ecryptfs_derive_iv
- * @iv: destination for the derived iv vale
+ * @iv: destination for the derived iv value
  * @crypt_stat: Pointer to crypt_stat struct for the current inode
  * @offset: Offset of the extent whose IV we are to derive
  *

[PATCH 2/2] ecryptfs: Drop TODO comment in ecryptfs_derive_iv

[Thorsten Blum]

Remove the TODO from 2006.

Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
---
 fs/ecryptfs/crypto.c | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/fs/ecryptfs/crypto.c b/fs/ecryptfs/crypto.c
index 585bad6577ed..92fbd28e9178 100644
--- a/fs/ecryptfs/crypto.c
+++ b/fs/ecryptfs/crypto.c
@@ -89,10 +89,6 @@ void ecryptfs_derive_iv(char *iv, struct ecryptfs_crypt_stat *crypt_stat,
 		ecryptfs_printk(KERN_DEBUG, "root iv:\n");
 		ecryptfs_dump_hex(crypt_stat->root_iv, crypt_stat->iv_bytes);
 	}
-	/* TODO: It is probably secure to just cast the least
-	 * significant bits of the root IV into an unsigned long and
-	 * add the offset to that rather than go through all this
-	 * hashing business. -Halcrow */
 	memcpy(src, crypt_stat->root_iv, crypt_stat->iv_bytes);
 	memset((src + crypt_stat->iv_bytes), 0, 16);
 	snprintf((src + crypt_stat->iv_bytes), 16, "%lld", offset);

Re: [PATCH 1/2] ecryptfs: Fix typo in ecryptfs_derive_iv function comment

[Tyler Hicks]

On Mon, 30 Mar 2026 12:35:15 +0200, Thorsten Blum wrote:
> s/vale/value/

Thank you! Both patches have been applied to the next branch of the tyhicks/ecryptfs.git tree.

You can find a direct link below but please be aware that the commit hash is
unstable and, therefore, the URL may not be valid in the future.

[1/2] ecryptfs: Fix typo in ecryptfs_derive_iv function comment
      https://git.kernel.org/tyhicks/ecryptfs/c/c8717a7fa5d2ea9048f398c16ab61d8e4c8f83b8
[2/2] ecryptfs: Drop TODO comment in ecryptfs_derive_iv
      https://git.kernel.org/tyhicks/ecryptfs/c/cd3b3094df0ee0f147957e7a7a1103990fdd6641

Tyler