From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0E78D1A6809; Tue, 7 Apr 2026 14:03:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.137.202.133 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775570626; cv=none; b=X6QaHhgF59FJ/qZ7vOM/jOuPUavxgJISn6PMVNgxH3o+BSzyjaXH0oIf1yj0OTEo+Zlc9ROmQUPQcI3DQEOcrWnwkSbv5rCaH32NKWJfniX1pAz5XHBPzNh+bp+/EA/4TX0qh7WhnE6+KeW9OqxI/feYC2d+bwiDOWiF1Dfhn7A= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775570626; c=relaxed/simple; bh=SzuhLG65FeCfSADNPY6sE7RMoVsiHkL6EfznsDyFJJI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=tyOoOfM3+YnMK06cwsIrAVlJQmItXxwwxpQcKRiFx6VQridrRPkQPHNv+U8im3bf5CDX0w3XMvPdEHm7LRi+iq2oFv3Z0ZNfLgEEGntdd8vr7/DJG9tCrZ8lsUHaoTyP/21RYNcQzaylIW4BXAUBS9af14Gb0hQ8NQGrnfe82W8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=lst.de; spf=none smtp.mailfrom=bombadil.srs.infradead.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b=Svj9trFS; arc=none smtp.client-ip=198.137.202.133 Authentication-Results: smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=lst.de Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bombadil.srs.infradead.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="Svj9trFS" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Sender :Reply-To:Content-Type:Content-ID:Content-Description; bh=uop5iib8V28wb5Rw5iMutCNVJf64/gxfx9aa2uF3lpU=; b=Svj9trFS/HpQPjgld3ULKsEqVT a/Fuj/dkEz8A/iX+FGXzdujykDgqC91rsWr1CazHoZm5tGtnlr5hY6dLRKwrZol5hWyVvpOkIk6gu fsZwW32uN8h5JeZfivln9omyZEd9TRY4Yb5wm8kiVfXOukx3Tr/K4RLFyV0uOj23jcy0sER9Z2ezj BULV+5zfvzqlKBkH4MIqs1SsXNKgU3fmbUI0D/lmwNc9sICnO2iPotOt83/vGX8eKbCVBSoJ3XyAX wx33QEXjtf33ETwl7SaJPEBqbhLvRhF/mQ44JB1mubkCbX29NuoZ0p+iTTSxvVM7/YBycePYZnBDn IYfbuL+Q==; Received: from 2a02-8389-2341-5b80-d601-7564-c2e0-491c.cable.dynamic.v6.surfer.at ([2a02:8389:2341:5b80:d601:7564:c2e0:491c] helo=localhost) by bombadil.infradead.org with esmtpsa (Exim 4.98.2 #2 (Red Hat Linux)) id 1wA71s-00000006YnK-0B4n; Tue, 07 Apr 2026 14:03:44 +0000 From: Christoph Hellwig To: Tyler Hicks Cc: ecryptfs@vger.kernel.org, linux-fsdevel@vger.kernel.org Subject: [PATCH 3/7] ecryptfs: use ZERO_PAGE instead of allocating zeroed memory in truncate_upper Date: Tue, 7 Apr 2026 16:02:39 +0200 Message-ID: <20260407140329.633186-4-hch@lst.de> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260407140329.633186-1-hch@lst.de> References: <20260407140329.633186-1-hch@lst.de> Precedence: bulk X-Mailing-List: ecryptfs@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Use the existing pre-zeroed memory instead of allocating a new chunk. Signed-off-by: Christoph Hellwig --- fs/ecryptfs/inode.c | 11 ++--------- 1 file changed, 2 insertions(+), 9 deletions(-) diff --git a/fs/ecryptfs/inode.c b/fs/ecryptfs/inode.c index 695573850569..daa63b7dd015 100644 --- a/fs/ecryptfs/inode.c +++ b/fs/ecryptfs/inode.c @@ -771,15 +771,8 @@ static int truncate_upper(struct dentry *dentry, struct iattr *ia, */ num_zeros = PAGE_SIZE - (ia->ia_size & ~PAGE_MASK); if (num_zeros) { - char *zeros_virt; - - zeros_virt = kzalloc(num_zeros, GFP_KERNEL); - if (!zeros_virt) { - rc = -ENOMEM; - goto out; - } - rc = ecryptfs_write(inode, zeros_virt, ia->ia_size, num_zeros); - kfree(zeros_virt); + rc = ecryptfs_write(inode, page_address(ZERO_PAGE(0)), + ia->ia_size, num_zeros); if (rc) { pr_err("Error attempting to zero out the remainder of the end page on reducing truncate; rc = [%d]\n", rc); -- 2.47.3