ecryptfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: andreym@codeaurora.org
To: Christoph Hellwig <hch@infradead.org>
Cc: Andrey Markovytch <andreym@codeaurora.org>,
	tyhicks@canonical.com, ecryptfs@vger.kernel.org,
	linaz@codeaurora.org, open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v1] eCryptfs: enhancing eCryptfs to be used with external crypto engine
Date: Wed, 11 Nov 2015 14:06:12 -0000	[thread overview]
Message-ID: <351897f46ec3c546dc2c20ecf5c7394f.squirrel@www.codeaurora.org> (raw)
In-Reply-To: <20151108092654.GA15861@infradead.org>

> On Sun, Nov 08, 2015 at 10:10:00AM +0200, Andrey Markovytch wrote:
>> +++ b/fs/ecryptfs/caches_utils.c
>> @@ -0,0 +1,78 @@
>> +/*
>> + * Copyright (c) 2015, The Linux Foundation. All rights reserved.
>
> Really?  This looks like copy and paste from core code that defintively
> was not written by the Linux Foundation.  In addition this patch comes
> from Qualcomm so something very fishy is going on here, which if I'd
> call copyrght fraud if I'd want to be be mean.
>
> Please a) stop pointlessly copy and pasting code and b) have a word with
> your lawyers on how to attribute code both that your wrote and which has
> been copy and pasted.
>

Hi Christoph,
Regarding the license, after double checking this, it seems that there has
been a mistake and we unproperly attributed Linux copyright for the code
that actually came from open source files having a different license. I
appologise for that, I am checking this internally and will update patch
with proper license.
As for the 'pointless copy paste', the code was taken from files where
those functions are declared as internal static, we had no choise but to
copy paste them, other option would be alternating the original code and
make those 2 functions public which seems unjustified in this case.

  reply	other threads:[~2015-11-11 14:06 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-08  8:10 [PATCH v1] eCryptfs: enhancing eCryptfs to be used with external crypto engine Andrey Markovytch
2015-11-08  9:26 ` Christoph Hellwig
2015-11-11 14:06   ` andreym [this message]
2015-11-09 17:55 ` Tyler Hicks
2015-11-09 20:56   ` andreym
2015-11-09 21:05     ` Tyler Hicks
2015-11-10 15:20       ` andreym
2015-11-10 15:27         ` andreym
2015-11-10 22:18         ` Tyler Hicks
2015-11-11 12:03           ` andreym
2015-11-11 20:55             ` Michael Halcrow
2015-11-12 20:23               ` andreym
2015-11-23 20:14                 ` andreym
2015-11-09 22:17     ` Michael Halcrow
  -- strict thread matches above, loose matches on Subject: below --
2015-11-08  8:14 Andrey Markovytch
2015-11-08  9:31 ` kbuild test robot
2015-11-08 11:06 ` kbuild test robot
2015-11-23 20:42 andreym

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=351897f46ec3c546dc2c20ecf5c7394f.squirrel@www.codeaurora.org \
    --to=andreym@codeaurora.org \
    --cc=ecryptfs@vger.kernel.org \
    --cc=hch@infradead.org \
    --cc=linaz@codeaurora.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tyhicks@canonical.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).