From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Subject: Re: [PATCH v2 0/2] Don't generate thousands of new warnings when building docs Date: Thu, 16 Apr 2020 13:05:39 +0300 Message-ID: <87a73b4ufg.fsf@intel.com> References: <20200320171020.78f045c5@lwn.net> Mime-Version: 1.0 Return-path: Received: from mga02.intel.com ([134.134.136.20]:38870 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2504378AbgDPKFy (ORCPT ); Thu, 16 Apr 2020 06:05:54 -0400 In-Reply-To: <20200320171020.78f045c5@lwn.net> Sender: ecryptfs-owner@vger.kernel.org List-ID: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Jonathan Corbet , Mauro Carvalho Chehab Cc: Linux Doc Mailing List , linux-kernel@vger.kernel.org, "Martin K. Petersen" , Paul Mackerras , Madhuparna Bhowmik , "David S. Miller" , Ricardo Ribalda Delgado , Luca Ceresoli , dmaengine@vger.kernel.org, Matthias Maennich , Harry Wei , x86@kernel.org, ecryptfs@vger.kernel.org, Jakub Kicinski , target-devel@vger.kernel.org, "H. Peter Anvin" , Hans Verkuil , Benjamin Herrenschmidt , Johannes Berg , Jacopo Mondi , Tyler Hicks <> On Fri, 20 Mar 2020, Jonathan Corbet wrote: > On Fri, 20 Mar 2020 16:11:01 +0100 > Mauro Carvalho Chehab wrote: > >> This small series address a regression caused by a new patch at >> docs-next (and at linux-next). > > I don't know how I missed that mess, sorry. I plead distracting times or > something like that. Heck, I think I'll blame everything on the plague > for at least the next few weeks. > > Anyway, I've applied this, thanks for cleaning it up. There's still more fallout from the autosectionlabel extension introduced in 58ad30cf91f0 ("docs: fix reference to core-api/namespaces.rst"), e.g. in i915.rst. The biggest trouble is, if you have headings in kernel-doc comments, Sphinx is unable pinpoint where the dupes are. For example: Documentation/gpu/i915.rst:610: WARNING: duplicate label gpu/i915:layout, other instance in Documentation/gpu/i915.rst However there is no "layout" label in i915.rst. The one being warned about I can dig into based on the line number, but not the second one. You have to resort to grepping the source. And avoiding duplicate subsection headings in completely isolated places is a minefield. BR, Jani. -- Jani Nikula, Intel Open Source Graphics Center