From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from fout-a5-smtp.messagingengine.com (fout-a5-smtp.messagingengine.com [103.168.172.148]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B3AF12144CA for ; Wed, 30 Oct 2024 21:08:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=103.168.172.148 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730322522; cv=none; b=AWJ7gxqHzEgYfnqWDG9UUDZ4/MjnlUJlNe5trMYki/hUges3V52CwdzQCDP9hnzkMnvemXKOwuAycmifsXiBMeQKwmMfYuvUNZK2iQi3lpk8j+kjkLFHNQRbLXjVk6cFRAFv4dBsHJzejvD4PREAWxrnSqMbAEiuhZVd3QhCF1E= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730322522; c=relaxed/simple; bh=MvFuDPqRHtlw+JArg+f6a3+WgB0wklulP+yGUcMl6uI=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=O4IuaCRsk77iyMPBgxlrcVLFghFchDt4m6BZW4pIErHDU1x7vCO9m1dJxsFxxnVEmBp4T6WuBvqAMJ8MluWDXlQRqUPzQ5f20XM3OLdgkBRmlEqismWTeKUKRPmiwTtJNcF7vpMUUTcY+O/t7vBwAn7Sg4R6dnIAgAINE0Na20g= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=tyhicks.com; spf=pass smtp.mailfrom=tyhicks.com; dkim=pass (2048-bit key) header.d=tyhicks.com header.i=@tyhicks.com header.b=Taoe1lOM; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b=NtgccIuK; arc=none smtp.client-ip=103.168.172.148 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=tyhicks.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=tyhicks.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=tyhicks.com header.i=@tyhicks.com header.b="Taoe1lOM"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="NtgccIuK" Received: from phl-compute-07.internal (phl-compute-07.phl.internal [10.202.2.47]) by mailfout.phl.internal (Postfix) with ESMTP id A233D13801DC; Wed, 30 Oct 2024 17:08:39 -0400 (EDT) Received: from phl-mailfrontend-02 ([10.202.2.163]) by phl-compute-07.internal (MEProxy); Wed, 30 Oct 2024 17:08:39 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tyhicks.com; h= cc:cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:subject :subject:to:to; s=fm2; t=1730322519; x=1730408919; bh=N2UdIzZ/o4 3LgKD64Q/ihe0vrthcCDCQxcLsZSjJD9I=; b=Taoe1lOM2zULSa6K26RdG1KTIz iCmCfMC7owozppADdoSLrvca4qTvPjf8o9c1X/tK7Scon4EmNWMLI8GB87CxriX3 hxGTDS/vEUOrMffZQZCG7d6R+oipzheHoMHGlWpM40+Hb/xnbc9LlokvjPmXkMTn pQSGBU+6iSNk0bYbMF0x2S38KT1kgt5pyt1ruLIpAJTO8Qh0HIgvCvKR4sxcf8K/ 1Pj+E8RXa8oKmiwbtAE1CRRGWGJPYuhl/QkmQhl/YRkdL57XcJ9LVTP+kjc/y0wk xWOn69nhABNJBm8denjvb4INQWGPKPp3+MuXIBD9D7gF57gsis78+4a8Z5og== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t= 1730322519; x=1730408919; bh=N2UdIzZ/o43LgKD64Q/ihe0vrthcCDCQxcL sZSjJD9I=; b=NtgccIuKQPALmqbyuNMpbUV2ZQFUlUv2VUMHMaYvKzhPIRWIjAK gSv9eABjQy1g1kRZd5UCMGVJ6U/ZvJyHc6OryUCFEoqHHzRxZGvlEfzINXetWTXr vn/UYvMqgN7zFgcj7GhGyapRb41UrIAwon1Ut3S9pChT8PgtzlSP4rnoRSf0HykO elXV0ZiSrb+5kn8HhqbZ9rLfdWZ8+rHNrxlbQ31wLzLS0ttF1Y0tAslcHv4Tn5lh Eoi8sEtIdjDifVLM1Kt0wjt289Mcdjvz7ewgxYBMX2o8P4slEHrigPzPO32wm3oX aKGgV30/sFZJPyE5XFJqoXID5TYGbFXpnwA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeftddrvdekfedgudeggecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpggftfghnshhusghstghrihgsvgdp uffrtefokffrpgfnqfghnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivg hnthhsucdlqddutddtmdenucfjughrpeffhffvvefukfhfgggtuggjsehttdertddttddv necuhfhrohhmpefvhihlvghrucfjihgtkhhsuceotghouggvsehthihhihgtkhhsrdgtoh hmqeenucggtffrrghtthgvrhhnpedvhedvtddthfefhfdtgfelheefgefgudejueevkedu veekvdegjedttdefgfelieenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmh grihhlfhhrohhmpegtohguvgesthihhhhitghkshdrtghomhdpnhgspghrtghpthhtohep fedpmhhouggvpehsmhhtphhouhhtpdhrtghpthhtohepshgrnhguvggvnhesrhgvughhrg htrdgtohhmpdhrtghpthhtohepvggtrhihphhtfhhssehvghgvrhdrkhgvrhhnvghlrdho rhhgpdhrtghpthhtohepsghrrghunhgvrheskhgvrhhnvghlrdhorhhg X-ME-Proxy: Feedback-ID: i78e14604:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 30 Oct 2024 17:08:38 -0400 (EDT) Date: Wed, 30 Oct 2024 16:08:37 -0500 From: Tyler Hicks To: Eric Sandeen Cc: ecryptfs@vger.kernel.org, brauner@kernel.org Subject: Re: [PATCH 2/2] ecryptfs: Convert ecryptfs to use the new mount API Message-ID: References: <20241007153448.6357-1-sandeen@redhat.com> <20241007153448.6357-3-sandeen@redhat.com> Precedence: bulk X-Mailing-List: ecryptfs@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On 2024-10-28 09:22:35, Eric Sandeen wrote: > On 10/21/24 9:07 AM, Eric Sandeen wrote: > > >>> + > >>> + opt = fs_parse(fc, ecryptfs_fs_param_spec, param, &result); > >>> + if (opt < 0) > >>> + return opt; > >>> + > >>> + switch (opt) { > >>> + case Opt_sig: > >>> + case Opt_ecryptfs_sig: > >>> + rc = ecryptfs_add_global_auth_tok(mount_crypt_stat, > >>> + param->string, 0); > >>> + if (rc) { > >>> + printk(KERN_ERR "Error attempting to register " > >>> + "global sig; rc = [%d]\n", rc); > >> > >> Are we expected to be using errorf() and friends here rather than > >> printk()? > > > > That's kind of a debate. If you'd rather get rid of the kernel message and > > send it out through the mount api message channel instead, I can make that > > change. But if userspace doesn't capture the message from errorf, that change > > would lose the message altogether. > > > > I kind of feel like once userspace is really making use of the message channel, > > we could go back and selectively change printks to the message channel where it > > makes sense. > > Ok, without any further input I'll send V2 w/ the whitespace and double semicolon > fixes, and leave the printks etc in place for the reasons stated above. Apologies. I agree that this was the correct approach for v2. > If anyone wants to redirect pritnks to the API message channel, that can always > be done as a followup patch. ecryptfs would certainly not be an outlier if it > leaves the printks in place for now. Thanks for that info. I'll review v2 shortly. Tyler > > -Eric >