EcryptFS development
 help / color / mirror / Atom feed
From: Tyler Hicks <code@tyhicks.com>
To: Alexey Velichayshiy <a.velichayshiy@ispras.ru>
Cc: ecryptfs@vger.kernel.org, linux-kernel@vger.kernel.org,
	lvc-project@linuxtesting.org
Subject: Re: [PATCH] ecryptfs: remove redundant variable found_auth_tok
Date: Mon, 20 Apr 2026 21:53:52 -0500	[thread overview]
Message-ID: <aebmwDc5nTFJpWyX@yaupon> (raw)
In-Reply-To: <177673965982.2803793.17321023234031184810.b4-ty@b4>

On 2026-04-20 21:50:58, Tyler Hicks wrote:
> On Sun, 12 Apr 2026 16:50:08 +0300, Alexey Velichayshiy wrote:
> > The found_auth_tok variable is no longer needed, as the fact of finding
> > a token is determined directly by jumping to the found_matching_auth_tok
> > label inside the loop.
> > 
> > Remove found_auth_tok, simplifying the function logic.
> > 
> > Found by Linux Verification Center (linuxtesting.org) with SVACE.
> > 
> > [...]
> 
> Thank you! This has been applied to the next branch of the tyhicks/ecryptfs.git tree.
> 
> Note that I made a small change by unsplitting the error message that is passed
> to ecryptfs_printk().
> 
> You can find a direct link below but please be aware that the commit hash is
> unstable and, therefore, the URL may not be valid in the future.
> 
> [1/1] ecryptfs: remove redundant variable found_auth_tok
>       https://git.kernel.org/tyhicks/ecryptfs/c/0be6d8f0e111deb765c0bc01c1fe5d9920fe2fcd

That link is not correct. The correct link is here:

 https://git.kernel.org/tyhicks/ecryptfs/c/eb5e768eaf7c5f6274319e2894ceebf0f3cb5750

Tyler

      reply	other threads:[~2026-04-21  2:54 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-12 13:50 [PATCH] ecryptfs: remove redundant variable found_auth_tok Alexey Velichayshiy
2026-04-21  2:50 ` Tyler Hicks
2026-04-21  2:53   ` Tyler Hicks [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aebmwDc5nTFJpWyX@yaupon \
    --to=code@tyhicks.com \
    --cc=a.velichayshiy@ispras.ru \
    --cc=ecryptfs@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lvc-project@linuxtesting.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox