From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from fout-b8-smtp.messagingengine.com (fout-b8-smtp.messagingengine.com [202.12.124.151]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6A4F718DB1F; Wed, 1 Jul 2026 03:45:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=202.12.124.151 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782877560; cv=none; b=QOwzynNMrnjGn9o/FGpAQhvpZX78O0iFfmYbMEhvEtLu88etVlWcss9tTdLgUxRcUiY2i8VH2uMgsMYURpEE8YKIVRVg6bANUYN6lmkJtJsVeFqGXyO+xwUWNluafjdSQCs3NOFARIZcLjf7roOQ3JVfUTizKhzSKwYYZbr09yo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782877560; c=relaxed/simple; bh=eaPBH/6sdGIqblv7TIlSP66nbTGsiuwEXH8L4y0Onow=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=pkTEgKEy82ezGQ+8YPjSF3MPt6ogE2krJxeVXUBsaaav92fDjioWiseR0bZurx6slsC/eyEYu8sV28g0Hc795Vf7aiBse8H3NDzvz3pewuH0xOvgQDrj/AComN3WqGxDRaViocenYu4HQsnFTI79w0YMyhItsVhSdnVDo+76IHk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=tyhicks.com; spf=pass smtp.mailfrom=tyhicks.com; dkim=pass (2048-bit key) header.d=tyhicks.com header.i=@tyhicks.com header.b=+cB/uZg5; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b=ZADKGo6U; arc=none smtp.client-ip=202.12.124.151 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=tyhicks.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=tyhicks.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=tyhicks.com header.i=@tyhicks.com header.b="+cB/uZg5"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="ZADKGo6U" Received: from phl-compute-01.internal (phl-compute-01.internal [10.202.2.41]) by mailfout.stl.internal (Postfix) with ESMTP id 5AEB11D0011E; Tue, 30 Jun 2026 23:45:57 -0400 (EDT) Received: from phl-frontend-03 ([10.202.2.162]) by phl-compute-01.internal (MEProxy); Tue, 30 Jun 2026 23:45:57 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tyhicks.com; h= cc:cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:subject :subject:to:to; s=fm1; t=1782877557; x=1782963957; bh=bAuxncmnHq mUQ7YU8kZ0VntL/R0qZmlPNJTnrZed/GE=; b=+cB/uZg5pJgL2vBqacfSkAuSj4 jJIReiHE0nPeoYlR5++T5OtI3PAtnwQBu6QsVzXfjoMqVUJIOGaILw8JcextACF/ rqNMOr/L94Uckt6I0fYPryGFxw4twzZLkETeVgmfqR4Jexx+Gl00KWtOmRqmQ4Kx Iy5BBf+9SmBa+9P6pOqpc5DX5QagJSeqO0TzgBsM98RKhD9Vg4WCktKZxY0czhjV /d0wolkqJLTrx+0eUBoLq+Rn9Lsvdxuay8uYsvCxcy51T6SNpgOzgkiLzd3/oUxB 4ErLyrZRcApo5YhTRMf2bfZGpRu9kvCCkg2P8WMqZOeB+GOnmiMFovlA/4fg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t= 1782877557; x=1782963957; bh=bAuxncmnHqmUQ7YU8kZ0VntL/R0qZmlPNJT nrZed/GE=; b=ZADKGo6UqWzOXg4avdWhr8qZz4Nf7jHgqKTl2hM3cMvfuxvrEGM 95D5dru7uWjJmU0dlaVsWd1c1huIgyFVgw1vhIj+GIrj8eVLtxjNKhU3mWTA59Ej TDC1CSxLXcIziOYmg9dW8OCLFZ+hc3ERlnmNquBpr9jp0ZamKlfUO5WjHOASjl5D N0vF7Q9QQJ9sY5RmkMKks8l1sdgvJJQ1orC32Hs0VbcUMMzMyXqKkavxl1ksRuQY Oi4UtZGtcAmFiTrigCiNgynbDkaeUhSwxnKMOCp9ZvZqm2mstbhoG0WBYTrfXCQP ZjyPx3JG1BeTqDMFY6jUwQnADXc73YzGs3w== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: dmFkZTFqXvXPjdywYh6eNJ2k9qv6UonLtrcRwhCxN7q7nY/sDQZ06gg9vG63yU/E7sXnxh pxLC/OL51vz4GtYiiF7lvhW/gVPXsBqA6BqJVPVW33EN1LypfZZK4m/V3UJHs2DFRm/epb I7oIk8qnpuq5h3IwbQiTJLk7AcrRCbK1h+RFaH6ThtSfhP6Z8I/YmD3he5oR1CUs8h8665 rYCTz/UAyL7BqVLT3+ARVoSgr1OBXI4c37LihQcKClOqyRfsaEHzlpnteZnKBm6X2P0+KX mYSm4+L9jR6aviY2a/1r2AMkFx/v1d2ey5FwHGDMTPxhNlZDmuhnOr0dMOYD8qPJdLjMSh 4tVm4vAVLVbAA6TEUQymyM/zRBDK3q4g0kZIWQ0UnX77S9C+I9PEaTXkUKkC+/YzMi1H0r uBgifz8DwjrWFDQFDSFESDL07hI/v/KGDSVlfAx+1PKsi1P3EOshY/YkvGAd2rdvSPNdhG VPnwI+SyZYDz0ejmyQLyfV5BliLsR6xKxLxPZgVuIUSbiXZlMWzQ0hJV5y1qnC6Ygfwwn7 71kMtCeckJeL6nXTlaV4KbJ9IHQU8Oud+fSM36zTgxFanaNfzMHPfMmPcMu3PxOscXM0Ri 7+j3U3QdBOBkdZGsxKBCll6eye4vZo5ZIF3vXSaBXYNl0cqb6uEEVdIPStFA X-ME-Proxy: Feedback-ID: i78e14604:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 30 Jun 2026 23:45:56 -0400 (EDT) Date: Tue, 30 Jun 2026 22:45:38 -0500 From: Tyler Hicks To: Yichong Chen Cc: Thorsten Blum , Kees Cook , ecryptfs@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ecryptfs: release message context on send failure Message-ID: References: <20260627090126.27607-1-chenyichong@uniontech.com> Precedence: bulk X-Mailing-List: ecryptfs@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260627090126.27607-1-chenyichong@uniontech.com> On 2026-06-27 17:01:26, Yichong Chen wrote: > ecryptfs_send_message_locked() moves a message context from the free > list to the allocated list before sending the request to the userspace > daemon. > > If ecryptfs_send_miscdev() fails, the context is left on the > allocated list and cannot be reused. Move it back to the free list on > failure and clear the caller's pointer. Hi - Thanks for the fix! > > Fixes: 624ae5284516 ("eCryptfs: remove netlink transport") I think the correct Fixes tag is: Fixes: f66e883eb618 ("eCryptfs: integrate eCryptfs device handle into the module.") Do you agree that is when this bug was first introduced? The rest of the patch looks good to me. Tyler > Signed-off-by: Yichong Chen > --- > fs/ecryptfs/messaging.c | 9 ++++++++- > 1 file changed, 8 insertions(+), 1 deletion(-) > > diff --git a/fs/ecryptfs/messaging.c b/fs/ecryptfs/messaging.c > index 03c60f0850ca..d53c21e82365 100644 > --- a/fs/ecryptfs/messaging.c > +++ b/fs/ecryptfs/messaging.c > @@ -284,9 +284,16 @@ ecryptfs_send_message_locked(char *data, int data_len, u8 msg_type, > mutex_unlock(&ecryptfs_msg_ctx_lists_mux); > rc = ecryptfs_send_miscdev(data, data_len, *msg_ctx, msg_type, 0, > daemon); > - if (rc) > + if (rc) { > printk(KERN_ERR "%s: Error attempting to send message to " > "userspace daemon; rc = [%d]\n", __func__, rc); > + mutex_lock(&ecryptfs_msg_ctx_lists_mux); > + mutex_lock(&(*msg_ctx)->mux); > + ecryptfs_msg_ctx_alloc_to_free(*msg_ctx); > + mutex_unlock(&(*msg_ctx)->mux); > + mutex_unlock(&ecryptfs_msg_ctx_lists_mux); > + *msg_ctx = NULL; > + } > out: > return rc; > } > -- > 2.51.0 >