From: Denis Kenzior <denkenz@gmail.com>
To: ell@lists.linux.dev
Cc: Denis Kenzior <denkenz@gmail.com>
Subject: [PATCH 07/12] netlink: support appending using scatter / gather
Date: Mon, 22 Jul 2024 14:04:24 -0500 [thread overview]
Message-ID: <20240722190443.43196-7-denkenz@gmail.com> (raw)
In-Reply-To: <20240722190443.43196-1-denkenz@gmail.com>
This version builds the attribute using scatter / gather semantics
(iovs) in order to minimize the number of copies required to build the
message.
---
ell/ell.sym | 1 +
ell/netlink.c | 34 ++++++++++++++++++++++++++++++++++
ell/netlink.h | 3 +++
3 files changed, 38 insertions(+)
diff --git a/ell/ell.sym b/ell/ell.sym
index 247786d5ee98..b99b6e552eaa 100644
--- a/ell/ell.sym
+++ b/ell/ell.sym
@@ -439,6 +439,7 @@ global:
l_netlink_message_ref;
l_netlink_message_unref;
l_netlink_message_append;
+ l_netlink_message_appendv;
l_netlink_message_add_header;
/* path */
l_basename;
diff --git a/ell/netlink.c b/ell/netlink.c
index 39c5bc335e19..d7294a95f20d 100644
--- a/ell/netlink.c
+++ b/ell/netlink.c
@@ -821,6 +821,40 @@ LIB_EXPORT int l_netlink_message_append(struct l_netlink_message *message,
return 0;
}
+LIB_EXPORT int l_netlink_message_appendv(struct l_netlink_message *message,
+ uint16_t type,
+ const struct iovec *iov, size_t iov_len)
+{
+ size_t len = 0;
+ void *dest;
+ size_t i;
+ int r;
+
+ if (unlikely(!message))
+ return -EINVAL;
+
+ for (i = 0; i < iov_len; i++)
+ len += iov[i].iov_len;
+
+ if (len > USHRT_MAX - NLA_HDRLEN)
+ return -ERANGE;
+
+ r = message_grow(message, NLA_HDRLEN + NLA_ALIGN(len));
+ if (r < 0)
+ return r;
+
+ r = add_attribute(message, type, len, &dest);
+ if (r < 0)
+ return r;
+
+ for (i = 0, len = 0; i < iov_len; i++, iov++) {
+ memcpy(dest + len, iov->iov_base, iov->iov_len);
+ len += iov->iov_len;
+ }
+
+ return 0;
+}
+
int netlink_message_reserve_header(struct l_netlink_message *message,
size_t len, void **out_header)
{
diff --git a/ell/netlink.h b/ell/netlink.h
index 70a55d652560..4d1c4761b3bb 100644
--- a/ell/netlink.h
+++ b/ell/netlink.h
@@ -53,6 +53,9 @@ struct l_netlink_message *l_netlink_message_ref(
void l_netlink_message_unref(struct l_netlink_message *message);
int l_netlink_message_append(struct l_netlink_message *message, uint16_t type,
const void *data, size_t len);
+int l_netlink_message_appendv(struct l_netlink_message *message,
+ uint16_t type,
+ const struct iovec *iov, size_t iov_len);
int l_netlink_message_add_header(struct l_netlink_message *message,
const void *header, size_t len);
--
2.45.2
next prev parent reply other threads:[~2024-07-22 19:04 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-22 19:04 [PATCH 01/12] useful: Add utility to find the next power of two Denis Kenzior
2024-07-22 19:04 ` [PATCH 02/12] unit: Add unit test for roundup_pow_of_two Denis Kenzior
2024-07-22 19:04 ` [PATCH 03/12] util: Introduce l_util_pagesize Denis Kenzior
2024-07-22 19:04 ` [PATCH 04/12] string: Use conservative allocation growth strategy Denis Kenzior
2024-07-22 19:04 ` [PATCH 05/12] unit: Refactor genl-msg tests Denis Kenzior
2024-07-22 19:04 ` [PATCH 06/12] netlink: Add l_netlink_message class Denis Kenzior
2024-07-22 19:04 ` Denis Kenzior [this message]
2024-07-22 19:04 ` [PATCH 08/12] netlink: Support adding nested attributes to messages Denis Kenzior
2024-07-22 19:04 ` [PATCH 09/12] netlink: Add additional helpers Denis Kenzior
2024-07-22 19:04 ` [PATCH 10/12] unit: Add netlink message builder / parser tests Denis Kenzior
2024-07-22 19:04 ` [PATCH 11/12] netlink: add netlink_message_from_nlmsg Denis Kenzior
2024-07-22 19:04 ` [PATCH 12/12] genl: Use l_netlink_message as implementation for l_genl_msg Denis Kenzior
2024-07-23 23:51 ` [PATCH 01/12] useful: Add utility to find the next power of two Denis Kenzior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240722190443.43196-7-denkenz@gmail.com \
--to=denkenz@gmail.com \
--cc=ell@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox