Embedded Linux Library
 help / color / mirror / Atom feed
From: Ryan Walklin <ryan@testtoast.com>
To: ell@lists.linux.dev
Cc: Ryan Walklin <ryan@testtoast.com>
Subject: [PATCH 1/2] ie: Fill in pending FILS IP Address responses
Date: Tue, 17 Nov 2026 11:35:38 +1300	[thread overview]
Message-ID: <20261116223609.3134127-2-ryan@testtoast.com> (raw)
In-Reply-To: <20261116223609.3134127-1-ryan@testtoast.com>

ie_parse_fils_ip_addr_response() returns 0 without writing to @out when
the IP address assignment pending flag is set.  station_connect_ok()
doesn't initialize its info structure, so it then acts on whatever was
on the stack: it may report the assignment as failed, as OK with all
zeros, or as OK with a garbage address, gateway and DNS server that get
installed as static configuration.  If the garbage doesn't pass
netconfig_load_fils_settings(), netconfig_configure() fails and the
station stays in the connecting (netconfig) state.

An iwd AP with no DHCP lease for the station always sends a pending
response, so this can be seen with an iwd AP and an iwd station that use
different network configuration settings.

Fixes: 8f5f62575db6 ("ie: Add FILS IP Address Assignment parsers and builders")
---
 src/ie.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/src/ie.c b/src/ie.c
index c8bb70b9..836cc587 100644
--- a/src/ie.c
+++ b/src/ie.c
@@ -2419,6 +2419,7 @@ int ie_parse_fils_ip_addr_response(struct ie_tlv_iter *iter,
 	if (info.response_pending) {
 		info.response_timeout =
 			bit_field(*resp_ctrl, 1, 6); /* seconds */
+		memcpy(out, &info, sizeof(info));
 		return 0;
 	}
 
-- 
2.55.0


  reply	other threads:[~2026-11-16 22:36 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-16 22:35 [PATCH 0/2] FILS IP address and station shutdown fixes Ryan Walklin
2026-11-16 22:35 ` Ryan Walklin [this message]
2026-11-16 22:35 ` [PATCH 2/2] station: Unregister BSS objects before freeing Ryan Walklin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261116223609.3134127-2-ryan@testtoast.com \
    --to=ryan@testtoast.com \
    --cc=ell@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox