From: Jens Axboe <axboe@kernel.dk>
To: vincentfu@gmail.com, fio@vger.kernel.org
Cc: Vincent Fu <vincent.fu@wdc.com>
Subject: Re: [PATCH] workqueue: update IO counters promptly after handling IO
Date: Mon, 26 Nov 2018 09:17:17 -0700 [thread overview]
Message-ID: <10409e85-cacf-d370-c742-20182961731d@kernel.dk> (raw)
In-Reply-To: <20181126161502.19992-1-vincentfu@gmail.com>
On 11/26/18 9:15 AM, vincentfu@gmail.com wrote:
> From: Vincent Fu <vincent.fu@wdc.com>
>
> Currently, IO submit worker threads only update parent IO counters when
> the threads are idle or when the threads exit. When offload fio jobs are
> assigned a restrictive CPU mask, this results in reporting and logging
> problems. This patch updates parent IO counters more promptly upon
> completing each IO which resolves the reporting and logging problems.
>
> In the output below, notice the missing read data direction output in
> the first, simple job and how it appropriately appears after the patch
> is applied. In the second job with logging, notice the missing log
> entries (unequal file sizes) in the first log and how entries are no
> longer missing for the run with the patch applied.
Looks good, thanks, applied.
--
Jens Axboe
prev parent reply other threads:[~2018-11-26 16:17 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-26 16:15 [PATCH] workqueue: update IO counters promptly after handling IO vincentfu
2018-11-26 16:17 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=10409e85-cacf-d370-c742-20182961731d@kernel.dk \
--to=axboe@kernel.dk \
--cc=fio@vger.kernel.org \
--cc=vincent.fu@wdc.com \
--cc=vincentfu@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox