From: Bart Van Assche <Bart.VanAssche@wdc.com>
To: "phillip.a.chen@seagate.com" <phillip.a.chen@seagate.com>
Cc: "sitsofe@gmail.com" <sitsofe@gmail.com>,
Kris Davis <Kris.Davis@wdc.com>,
Jason Jorgensen <jason.jorgensen@wdc.com>,
"fio@vger.kernel.org" <fio@vger.kernel.org>,
Damien Le Moal <Damien.LeMoal@wdc.com>
Subject: Re: ZBC/FLEX FIO addition ideas
Date: Thu, 15 Mar 2018 21:01:13 +0000 [thread overview]
Message-ID: <1521147672.2834.37.camel@wdc.com> (raw)
In-Reply-To: <CAODBMzk6+f0Hjn-uuzz6rmS0idH1oSD21D8rd21rd9Qhqv+-VQ@mail.gmail.com>
On Thu, 2018-03-15 at 13:40 -0600, Phillip Chen wrote:
> I haven't used the profile argument for FIO before, so when I read
> profile I thought it was being used as a synonym I/O profile or
> workload. So I think you're right that we shouldn't be creating a new
> profile for ZBC but rather focusing on the existing FIO generated
> workloads.
> When I was talking about valid I meant that get_next_block() would
> generate IO that would not cause errors or read filler data past the
> write pointer rather than having zbc_adjust_block() modify the IO
> afterwards.
> You make a good point that the two approaches can easily coexist. If
> you get your changes added I would like to try and build the
> additional workloads on top of your existing changes so that I can
> leverage your write pointer tracking code.
Hello Phillip,
That sounds like a plan to me :-) Can you have a look at the following code:
https://github.com/bvanassche/fio/tree/zbc. The quick fio tests I ran with
this code work fine with the ZBC and ZAC disks I tried.
I will send that code to Jens once the following two pull requests have been
accepted:
* "Improvements for analyzing fio with Valgrind"
(https://github.com/axboe/fio/pull/560).
* "Add an asprintf() implementation" (https://github.com/axboe/fio/pull/561).
Thanks,
Bart.
next prev parent reply other threads:[~2018-03-15 21:01 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-06 18:59 ZBC/FLEX FIO addition ideas Phillip Chen
2018-03-15 16:15 ` Kris Davis
2018-03-15 16:30 ` Sitsofe Wheeler
2018-03-15 16:43 ` Bart Van Assche
2018-03-15 18:06 ` Phillip Chen
2018-03-15 18:38 ` Bart Van Assche
2018-03-15 19:40 ` Phillip Chen
2018-03-15 21:01 ` Bart Van Assche [this message]
2018-03-17 7:55 ` Sitsofe Wheeler
2018-03-20 2:21 ` Bart Van Assche
2018-03-23 17:30 ` Phillip Chen
2018-03-23 17:35 ` Bart Van Assche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1521147672.2834.37.camel@wdc.com \
--to=bart.vanassche@wdc.com \
--cc=Damien.LeMoal@wdc.com \
--cc=Kris.Davis@wdc.com \
--cc=fio@vger.kernel.org \
--cc=jason.jorgensen@wdc.com \
--cc=phillip.a.chen@seagate.com \
--cc=sitsofe@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox