Re: [PATCH 2/2] zbd: Remove unused function and variable

[Bart Van Assche <bart.vanassche@gmail.com>]

On Wed, 2018-09-26 at 15:42 +0900, Damien Le Moal wrote:
> -/* Check whether the value of zbd_info.sectors_with_data is correct. */
> -static void check_swd(const struct thread_data *td, const struct fio_file *f)
> -{
> -#if 0
> -	struct fio_zone_info *zb, *ze, *z;
> -	uint64_t swd;
> -
> -	zb = &f->zbd_info->zone_info[zbd_zone_idx(f, f->file_offset)];
> -	ze = &f->zbd_info->zone_info[zbd_zone_idx(f, f->file_offset +
> -						  f->io_size)];
> -	swd = 0;
> -	for (z = zb; z < ze; z++) {
> -		pthread_mutex_lock(&z->mutex);
> -		swd += z->wp - z->start;
> -	}
> -	pthread_mutex_lock(&f->zbd_info->mutex);
> -	assert(f->zbd_info->sectors_with_data == swd);
> -	pthread_mutex_unlock(&f->zbd_info->mutex);
> -	for (z = zb; z < ze; z++)
> -		pthread_mutex_unlock(&z->mutex);
> -#endif
> -}

I'd like to keep this code. This code has been proven to be very valuable
while debugging to verify the code that updates f->zbd_info->sectors_with_data.

Bart.