From: Bart Van Assche <bvanassche@acm.org>
To: Damien Le Moal <damien.lemoal@wdc.com>,
fio@vger.kernel.org, Jens Axboe <axboe@kernel.dk>
Subject: Re: [PATCH] zbd: Use bytes unit
Date: Thu, 27 Sep 2018 07:59:00 -0700 [thread overview]
Message-ID: <1538060340.226558.1.camel@acm.org> (raw)
In-Reply-To: <20180831044813.22556-1-damien.lemoal@wdc.com>
On Fri, 2018-08-31 at 13:48 +0900, Damien Le Moal wrote:
> Simplify zbd.c code by using byte unit for the zone information values
> instead of 512B sector count. Doing so, many 9 bits shift operations
> are removed and code readability improved.
This patch is incomplete. The following documentation in zbd.h should also
updated to reflect the unit changes:
/**
* struct fio_zone_info - information about a single ZBD zone
* @start: zone start in 512 byte units
* @wp: zone write pointer location in 512 byte units
* @verify_block: number of blocks that have been verified for this zone
* @mutex: protects the modifiable members in this structure
* @type: zone type (BLK_ZONE_TYPE_*)
* @cond: zone state (BLK_ZONE_COND_*)
* @open: whether or not this zone is currently open. Only relevant if
* max_open_zones > 0.
* @reset_zone: whether or not this zone should be reset before writing to it
*/
struct fio_zone_info {
Thanks,
Bart.
prev parent reply other threads:[~2018-09-27 14:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-31 4:48 [PATCH] zbd: Use bytes unit Damien Le Moal
2018-09-27 14:59 ` Bart Van Assche [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1538060340.226558.1.camel@acm.org \
--to=bvanassche@acm.org \
--cc=axboe@kernel.dk \
--cc=damien.lemoal@wdc.com \
--cc=fio@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox