From: Jens Axboe <axboe@kernel.dk>
To: Bart Van Assche <Bart.VanAssche@wdc.com>
Cc: "fio@vger.kernel.org" <fio@vger.kernel.org>,
"gv.kovai@gmail.com" <gv.kovai@gmail.com>
Subject: Re: fio and zone support
Date: Tue, 10 Jul 2018 09:36:31 -0600 [thread overview]
Message-ID: <15e215bc-76ea-b65e-c79b-116758bea445@kernel.dk> (raw)
In-Reply-To: <1fc030d5ba842b0324bd2fd4333edc31d2eae652.camel@wdc.com>
On 7/10/18 9:32 AM, Bart Van Assche wrote:
> Hello Jens,
>
> In __fill_io_u_zone() I found the following code (see also commit 224b3093cc21
> ("Fix zoning issue with seq-io and randommap issue")):
>
> /*
> * Wrap from the beginning, if we exceed the file size
> */
> if (f->file_offset >= f->real_file_size)
> f->file_offset = f->real_file_size - f->file_offset;
>
> If f->file_offset > f->real_file_size then f->real_file_size - f->file_offset
> will be negative and hence the above assignment will store a negative number
> in f->file_offset. Is that what the above code is intended to do?
No, that looks wrong. But looking at the commit, it basically just moved
that code, so the issue predates that particular change.
--
Jens Axboe
prev parent reply other threads:[~2018-07-10 15:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-10 15:32 fio and zone support Bart Van Assche
2018-07-10 15:36 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=15e215bc-76ea-b65e-c79b-116758bea445@kernel.dk \
--to=axboe@kernel.dk \
--cc=Bart.VanAssche@wdc.com \
--cc=fio@vger.kernel.org \
--cc=gv.kovai@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox